Repository navigation
Terminus site backup get --element=db #215 - #217
SaraMcCutcheon merged 9 commits into
Conversation
… accepted element parameter values.
…w element db value.
|
@jcandan quick question, why not just normalize the value at the site() function of php/commands/site.php. Just curious. This looks good to me. |
There was a problem hiding this comment.
Also, should we allow 'database' as a valid input here so as not to break existing scripts?
|
not sure what you mean by "normalize the value at the |
|
@mikevanwinkle made suggested improvement. let me know your thots. thx! |
|
This also addresses #216. |
|
@jcandan I just meant that if you modify site.php to transform "database" into "db" then all the changes to the Environment file seem to be unnecessary. I feel like one place of the other should be responsible for the transformation and not both and I was just curious why you picked Environment.php instead of site.php. |
|
@mikevanwinkle I guess I was thinking it'd be best to correct the bug, since |
|
@mikevanwinkle, so, what do you think? |
|
@mikevanwinkle so, no go, eh? |
|
This looks good,, @jcandan. Thanks! I'll merge it into master. |
…_db-215 Terminus site backup get --element=db #215
This addresses issue #215