Visitar URL original
Use `pypyX.Y` for PyPy `python-version` input by mayeut · Pull Request #349 · actions/setup-python · GitHub
Skip to content

Use pypyX.Y for PyPy python-version input - #349

Merged
vsafonkin merged 1 commit into
actions:mainfrom
mayeut:pypyX.Y
May 18, 2022
Merged

Use pypyX.Y for PyPy python-version input#349
vsafonkin merged 1 commit into
actions:mainfrom
mayeut:pypyX.Y

Conversation

@mayeut

@mayeut mayeut commented Mar 5, 2022 •
edited
Loading

Copy link
Copy Markdown
Contributor

Description:
Use pypyX.Y for PyPy python-version input

This versioning scheme is consistent with other tools in the python ecosystem so it feels more natural and allows better interaction with other tools.

pypy-X.Y kept for backward compatibility.

Full rationale provided in #346.

Related issue:
fixes #346

Check list:

  • Mark if documentation changes are required.
  • Mark if tests were added or updated to cover the changes.

@mayeut mayeut changed the title Use pypyX.Y for PyPy python-version input Use pypyX.Y for PyPy python-version input Mar 5, 2022
@mayeut

mayeut commented Mar 5, 2022 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

An example can be seen here: https://github.com/mayeut/packaging/runs/5434696104?check_suite_focus=true
The associated workflow definition can be found here:
https://github.com/mayeut/packaging/blob/10d1ce220fd1847c9635190d45e72e7c1365644d/.github/workflows/test.yml#L17-L37
The diff to previous workflow file:

       matrix:
        os: [Ubuntu, Windows, macOS]
        python_version:
-         ["3.7", "3.8", "3.9", "3.10", "pypy-3.7", "pypy-3.8", "pypy-3.9"]
+         ["3.7", "3.8", "3.9", "3.10", "pypy3.7", "pypy3.8", "pypy3.9"]

    steps:
      - uses: actions/checkout@v1

      - uses: mayeut/setup-python@install-pypyX.Y-symlinks
      - uses: mayeut/setup-python@pypyX.Y
        name: Install Python ${{ matrix.python_version }}
        with:
          python-version: ${{ matrix.python_version }}

      - name: Run nox
-       run: |
-         INTERPRETER_SPEC=${{ matrix.python_version }}
-         INTERPRETER_SPEC=${INTERPRETER_SPEC/-/}  # remove '-' in "pypy-3.x" -> "pypy3.x" to match executable name
-         pipx run nox --error-on-missing-interpreters -s tests-${INTERPRETER_SPEC}
-       shell: bash
+       run: pipx run nox --error-on-missing-interpreters -s tests-${{ matrix.python_version }}

@mayeut mayeut mentioned this pull request Mar 6, 2022
Closed
@mayeut
mayeut force-pushed the pypyX.Y branch 3 times, most recently from a9cf09d to 843ba5d Compare April 9, 2022 09:29
@mayeut mayeut mentioned this pull request Apr 28, 2022
Merged
1 of 2 tasks
@mayeut
mayeut marked this pull request as ready for review April 28, 2022 16:14
@mayeut
mayeut requested a review from a team April 28, 2022 16:14
@mayeut

mayeut commented Apr 28, 2022 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

The 4 failing pypy-3.7-nightly tests are related to https://buildbot.pypy.org/nightly/ being down.

@mayeut

mayeut commented May 7, 2022

Copy link
Copy Markdown
Contributor Author

@vsafonkin, @dmitry-shibanov,

do you know when you'll be able to review this ?
any clarification needed on my part ?

dmitry-shibanov
dmitry-shibanov reviewed May 7, 2022
View reviewed changes
Comment thread src/find-pypy.ts Resolved
dmitry-shibanov
dmitry-shibanov reviewed May 7, 2022
View reviewed changes
Comment thread README.md Resolved
Comment thread README.md Resolved
@dmitry-shibanov

dmitry-shibanov commented May 7, 2022

Copy link
Copy Markdown
Contributor

Hello @mayeut. Could you please also sync with the main branch ?

mayeut
mayeut commented May 7, 2022
View reviewed changes
Comment thread README.md Resolved
@mayeut
mayeut force-pushed the pypyX.Y branch 2 times, most recently from d8c69b7 to 98b28db Compare May 7, 2022 22:28
@mayeut
Use pypyX.Y for PyPy python-version input
35e4601 
This versioning scheme is consistent with other
tools in the python ecosystem so it feels more natural
and allows better interaction with other tools.

fixes actions#346
@mayeut

mayeut commented May 7, 2022

Copy link
Copy Markdown
Contributor Author

thanks for the review @dmitry-shibanov, all your comments have been addressed.

@vsafonkin
vsafonkin merged commit fff15a2 into actions:main May 18, 2022
@vsafonkin

vsafonkin commented May 18, 2022

Copy link
Copy Markdown

@mayeut, thank you for your contribution!

@mayeut
mayeut deleted the pypyX.Y branch May 18, 2022 20:07
@EwoutH

EwoutH commented May 19, 2022

Copy link
Copy Markdown

Could a new release be tagged, to be able to use this syntax?

@vsafonkin

vsafonkin commented May 19, 2022 •
edited
Loading

Copy link
Copy Markdown

Could a new release be tagged, to be able to use this syntax?

Hi @EwoutH, a new version of the action will be released in the coming days.

@EwoutH

EwoutH commented May 24, 2022

Copy link
Copy Markdown

Hi @EwoutH, a new version of the action will be released in the coming days.

Awesome, looking forward to it!

@waylan waylan mentioned this pull request May 24, 2022
Merged
@kratsg kratsg mentioned this pull request Nov 30, 2022
Merged
tdfacer pushed a commit to ifit/setup-python that referenced this pull request Oct 7, 2025
@mayeut
Use pypyX.Y for PyPy python-version input (actions#349)
742dede 
This versioning scheme is consistent with other
tools in the python ecosystem so it feels more natural
and allows better interaction with other tools.

fixes actions#346
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

3 more reviewers
@vsafonkin vsafonkin vsafonkin approved these changes
@dmitry-shibanov dmitry-shibanov dmitry-shibanov approved these changes
@marko-zivic-93 marko-zivic-93 marko-zivic-93 approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Use pypyX.Y for PyPy python-version input

5 participants

@mayeut @dmitry-shibanov @vsafonkin @EwoutH @marko-zivic-93