Repository navigation
fix(options)!: Make not_planned the default close-issue-reason - #807
Merged
Merged
Conversation
GitHub introduced an additional close reason 'Close as not planned': https://github.blog/changelog/2022-05-19-the-new-github-issues-may-19th-update/ 'stale' is a use case for this close reason Fixes actions#789 BREAKING CHANGE: `close-issue-reason` defaults to `not_planned` (previously: `` which defaulted to `completed`) This closes the issue as 'not planned' on GitHub rather than 'completed' See: https://github.blog/changelog/2022-05-19-the-new-github-issues-may-19th-update
david-allison
force-pushed
the
fix-789
branch
from
September 14, 2022 10:16
a010cce to
71b8653
Compare
Contributor
Author
|
Fixed conflicts. Is anything required on my end to get this merged? |
jeffwidman
approved these changes
Sep 19, 2022
There was a problem hiding this comment.
This seems like the sane default.
I realize it's technically a breaking change so may require a v6, but I doubt many users have workflow that changes base on the close-issue-reason attribute so blast radius is probably pretty small... could also argue that the previous value was simply "unset" and this isn't so much a breaking change as simply a "enhancement" of setting the value...
Closed
luketomlinson
approved these changes
Sep 20, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
close-issue-reasondefaults tonot_planned(previously: ``which defaulted to
completed) This closes the issue as 'not planned' on GitHub rather than 'completed'Context
GitHub introduced an additional close reason 'Close as not planned':
https://github.blog/changelog/2022-05-19-the-new-github-issues-may-19th-update/
'stale' is a use case for this close reason and makes sense as a default for this action
Fixes #789
Feature added: 06d2a39
Updated: aaab997