Repository navigation
Content-type header for application/json should not contain charset field, according do RFC 8259 #2154
Description
Describe the bug
According to RFC 8259 - The JavaScript Object Notation (JSON) Data Interchange Format content-type application/json does not have any charset defined, as it must be utf-8 encoded. Older specifications allowed other unicode encodings, and parsers were detecting exact encoding used by first four bytes, still not by charset param.
Axios defaults to header Content-Type: application/json;charset=utf-8 for some types of sent data.
This breaks some HTTP servers and applications, who are not recognizing the content-type.
To Reproduce
axios.post("http://example.com", {an: "object"});
// Content-Type: application/json;charset=utf-8 header will be setExpected behavior
Content-Type: application/json header should be set as default for object data, without charset parameter.
Environment:
- Axios Version - 0.18.0, I've also checked master branch source - it is still there.
Line 52 in b4c5d35
Additional context/Screenshots
This breaks some parts of the rabbitmq-management API.
Related issues:
#859
Activity
mpark86 commentedon Dec 13, 2019
Is there any update on this issue? I'd like to try creating a PR for this.
chinesedfan commentedon Feb 26, 2020
See #2603 (comment). Thanks for @mpark86' pull request anyway.
And if you don't like it, you can replace it easily by configuring
transformRequest.OJezu commentedon Feb 26, 2020
@chinesedfan just Ctrl+F the RFC referenced in that comment and in this issue.
chinesedfan commentedon Feb 26, 2020
@OJezu I am not sure I get what you means. I guess you are proving your point. According to RFC 8259, the charset is not required and some servers are not supported to parse it.
Never mind, at least MDN includes the charset. More servers work well with it. And as I said, if you don't like it, you can replace it easily by configuring
transformRequest. Thanks for understanding.OJezu commentedon Feb 26, 2020
@chinesedfan what I'm proving, is that application/json type does not have "charset" defined. Providing it is non-standard, no matter what the servers do with it.
Axios is behaving in a way not specified in standard, and this is what the issue is about. Common errors alone in other software are not a reason to break RFC.
chinesedfan commentedon Feb 26, 2020
@OJezu After read more carefully, I think they are 2 things.
application/json.Content-Typeis defined in RFC 7231, instead of RFC 8259. And its format ismedia-type charset boundary. So axios doesn't break any BFCs.OJezu commentedon Feb 26, 2020
@chinesedfan where in RFC7231 is charset parameter defined for application/json? It's not, because parameter names are defined for concrete media-types in appropriate RFCs.
charsetparameter is neither declared for all headers nor for all media-types.application/jsonmedia-type does not have "charset" parameter defined.From RFC7231
See IANA media type registry for
application/json:https://www.iana.org/assignments/media-types/application/json
And compare to
plain/htmlentry which hascharsetparameter explicitly defined:https://www.iana.org/assignments/media-types/text/html
chinesedfan commentedon Feb 26, 2020
@OJezu I see. Now you have persuaded me.
application/jsonis different with other media types.alexandr2110pro commentedon Apr 24, 2020
Any progress on that?
3 remaining items
Add chartset=utf-8 to UAA axios password request
fix: remove charset from tests
chore: upgrade to Axios 0.25 (#437)