Visitar URL original
HttpConnection.getBytesIn() incorrect for requests with chunked content · Issue #6105 · jetty/jetty.project · GitHub
Skip to content

HttpConnection.getBytesIn() incorrect for requests with chunked content  #6105

New issue
New issue
Closed
#6145
#6108
Closed
HttpConnection.getBytesIn() incorrect for requests with chunked content #6105
#6145
#6108
Assignees
sbordet

Description

@bjorncs
bjorncs
opened on Mar 25, 2021

Jetty version
9.4.38.v20210224

Java version
11.0.7+10

OS type/version
MacOS 10.15.7

Description
HttpConnection.bytesIn is only aggregated when fillRequestBuffer() is called from onFillable(), not from fillAndParseForContent(). The result is that HttpConnection.getBytesIn() reports a value lower than than the actual number of bytes filled. I have been able to reproduce this for POST requests using chunked encoding.

Activity

  1. sbordet commented on Mar 25, 2021

    @sbordet
    sbordet
    on Mar 25, 2021
    Contributor

    @bjorncs thanks for the report, we'll work on the Jetty issue.
    How urgent is this for you?

  2. bjorncs commented on Mar 26, 2021

    @bjorncs
    bjorncs
    on Mar 26, 2021
    ContributorAuthor

    It's not a blocker - we only use the value for logging purposes at the moment.

  3. sbordet
    self-assigned this
    on Mar 26, 2021
  4. sbordet
    added 2 commits that reference this issue on Mar 26, 2021

    Fixes #6105 - HttpConnection.getBytesIn() incorrect for requests with…

    5f0bd97

    Issue #6105 - HttpConnection.getBytesIn() incorrect for requests with…

    9e8309a
  5. sbordet
    linked a pull request that will close this issueFixes #6105 - HttpConnection.getBytesIn() incorrect for requests with… #6108on Mar 26, 2021

  6. sbordet commented on Mar 26, 2021

    @sbordet
    sbordet
    on Mar 26, 2021
    Contributor

    @bjorncs can you try the code in PR #6108?

  7. sbordet
    added 2 commits that reference this issue on Apr 8, 2021

    Fixes #6105 - HttpConnection.getBytesIn() incorrect for requests with… (

    aed20ab

    Fixes #6105 - HttpConnection.getBytesIn() incorrect for requests with…

    5ced37e

  8. joakime commented on Apr 8, 2021

    @joakime
    joakime
    on Apr 8, 2021
    Contributor

    Closing, as PR #6108 was merged.

  9. joakime
    closed this as completedon Apr 8, 2021
  10. sbordet
    added a commit that references this issue on Apr 10, 2021

    Fixes #6105 - HttpConnection.getBytesIn() incorrect for requests with…

    e163b00
  11. sbordet
    linked a pull request that will close this issueFixes #6105 - HttpConnection.getBytesIn() incorrect for requests with chunked content #6145on Apr 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

No labels
No labels

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions