Repository navigation
Docs: add more examples for no-sequences rule - #14578
Conversation
eslint-github-bot
Bot
added
the
triage
aladdin-add
added
accepted
mdjermanovic
left a comment
mdjermanovic
left a comment
There was a problem hiding this comment.
The added examples LGTM, but since we already had a similar example with arrow function (right above the new examples) I think the idea in #14572 (comment) was to add a note. @nzakas ?
|
Yes, I think we should add a note that explicitly states this exception case as it’s different from anywhere else in the rule. |
|
@snitin315 are you still working on this? |
|
Yes, thanks for the ping. I will push an update today. |
|
Done ✅ |
nzakas
left a comment
nzakas
left a comment
There was a problem hiding this comment.
I was more thinking we should have a specific paragraph in the page saying something like:
Note about arrow function bodies
If an arrow function body is a statement rather than a block, and that statement contains a sequence, you need to use double parentheses around the statement to indicate that the sequence is intentional.
(include examples here)
nzakas
left a comment
nzakas
left a comment
There was a problem hiding this comment.
Exactly what I was looking for. Thank you!
| /*eslint no-sequences: "error"*/ | ||
| const foo = (val) => (console.log('bar'), val); | ||
|
|
||
| const foo = () => ((bar = 123), 10)); |
There was a problem hiding this comment.
These is an extra ) in this example.
There was a problem hiding this comment.
Good catch, thanks. I will send a fix.
eslint-github-bot
Bot
added
the
archived due to age
5 participants
Prerequisites checklist
What is the purpose of this pull request? (put an "X" next to an item)
[X] Documentation update
[ ] Bug fix (template)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add autofixing to a rule
[ ] Add a CLI option
[ ] Add something to the core
[ ] Other, please explain:
What changes did you make? (Give an overview)
Add more examples.
Fixes #14572
Is there anything you'd like reviewers to focus on?
Nope