Visitar URL original
Update filter for unsafe cast operator for Kotlin 1.4 by Godin · Pull Request #1143 · jacoco/jacoco · GitHub
Skip to content

Update filter for unsafe cast operator for Kotlin 1.4 - #1143

Merged
marchof merged 9 commits into
masterfrom
kotlin_1_4_unsafe_cast
Jan 5, 2021
Merged

marchof merged 9 commits into
masterfrom
kotlin_1_4_unsafe_cast

Conversation

@Godin

@Godin Godin commented Dec 18, 2020 •

Copy link
Copy Markdown
Member

Fixes #1134

@Godin
Godin marked this pull request as ready for review January 5, 2021 14:54
@Godin

Godin commented Jan 5, 2021

Copy link
Copy Markdown
Member Author

@marchof could you please review?

Since for implementation of unsafe cast Kotlin compiler now uses generic NullPointerException I hardened filter to not run on non-Kotlin classes and to hopefully remove possibility of filtering hand-written code, i.e. so far can't imagine hand-written Kotlin code that compiles into dup instruction followed by null-check.

Merge of this PR will also allow further update of Kotlin to 1.4.20 in org.jacoco.core.test.validation.kotlin during resolution of #1126.

@marchof
marchof merged commit e859274 into master Jan 5, 2021
@marchof
marchof deleted the kotlin_1_4_unsafe_cast branch January 5, 2021 18:37
@Godin Godin added the language: Kotlin Tickets about Kotlin language support label Oct 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

Archived in project
Status: Done

Development

Successfully merging this pull request may close these issues.

Kotlin 1.4 uses NullPoinerException instead of TypeCastException, KotlinUnsafeCastOperatorFilter no more filters 'unsafe' branch

3 participants