Visitar URL original
Changelog 42.2.24 by davecramer · Pull Request #2258 · pgjdbc/pgjdbc · GitHub
Skip to content

Changelog 42.2.24 - #2258

Merged
davecramer merged 6 commits into
pgjdbc:release/42.2from
davecramer:changelog42.2.24
Sep 23, 2021
Merged

davecramer merged 6 commits into
pgjdbc:release/42.2from
davecramer:changelog42.2.24

Conversation

@davecramer

Copy link
Copy Markdown
Member

Last version before 42.3.0
Want to leave a working version of 42.2.x

@jorsol
jorsol self-requested a review September 22, 2021 15:46
Comment thread CHANGELOG.md Resolved
@jorsol

jorsol commented Sep 22, 2021

Copy link
Copy Markdown
Member

I just found that some dates of the releases don't correspond with the real release date on Maven Central, I could send a commit fixing those in your branch also a small clean-up of empty sections.

@vlsi

vlsi commented Sep 22, 2021

Copy link
Copy Markdown
Member

Just in case: the release becomes official only after the official announcement at pgsql-jdbc mailing list, so it can easily be so that artifacts are deployed a couple of days before the announcement.

Comment thread CHANGELOG.md Resolved
@jorsol

jorsol commented Sep 22, 2021

Copy link
Copy Markdown
Member

Just in case: the release becomes official only after the official announcement at pgsql-jdbc mailing list, so it can easily be so that artifacts are deployed a couple of days before the announcement.

Ok, there is a small mismatch on what we consider the release date, the official announcement (at pgsql-announce mailing list) is normally after the artifacts are deployed, yet the date in the changelog is normally set to the commit date of the changelog, and even that might not be correct since the artifacts could be deployed after.

The most prominent example is the 4.2.20 release:

  • CHANGELOG.md -> 2021-04-19 (commit date or when it was drafted)
  • Artifacts deployed (Maven Central) -> 2021-04-22
  • pgsql-announce -> 2021-04-23

Anyway, this is a discussion for another time.

@davecramer

Copy link
Copy Markdown
Member Author

Just in case: the release becomes official only after the official announcement at pgsql-jdbc mailing list, so it can easily be so that artifacts are deployed a couple of days before the announcement.

Ok, there is a small mismatch on what we consider the release date, the official announcement (at pgsql-announce mailing list) is normally after the artifacts are deployed, yet the date in the changelog is normally set to the commit date of the changelog, and even that might not be correct since the artifacts could be deployed after.

The most prominent example is the 4.2.20 release:

  • CHANGELOG.md -> 2021-04-19 (commit date or when it was drafted)
  • Artifacts deployed (Maven Central) -> 2021-04-22
  • pgsql-announce -> 2021-04-23

Anyway, this is a discussion for another time.

Ya, I'm not terribly worried about the mismatch in dates. Thanks for the review though

@jorsol

jorsol commented Sep 22, 2021

Copy link
Copy Markdown
Member

I have pushed a commit to your branch (you can do a pull to get the change in your local branch) with some small fixes in the formatting structure, and also removed the last item since it looks like a duplicate for the second item.

@jorsol jorsol left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Haven't checked the items one by one but LGTM

@davecramer

Copy link
Copy Markdown
Member Author

I'm going to let this age for a day then push it tomorrow, tag it and release it.

@jorsol

jorsol commented Sep 22, 2021

Copy link
Copy Markdown
Member

I'm going to let this age for a day then push it tomorrow, tag it and release it.

Then this is a reminder to update the date to 2021-09-23 😉

@davecramer
davecramer merged commit 512799b into pgjdbc:release/42.2 Sep 23, 2021
@davecramer
davecramer deleted the changelog42.2.24 branch September 23, 2021 10:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants