Visitar URL original
added dialect by DvirDukhan · Pull Request #2960 · redis/jedis · GitHub
Skip to content

added dialect - #2960

Merged
sazzad16 merged 5 commits into
redis:masterfrom
DvirDukhan:redisearch_query_dialect
Mar 31, 2022
Merged

added dialect#2960
sazzad16 merged 5 commits into
redis:masterfrom
DvirDukhan:redisearch_query_dialect

Conversation

@DvirDukhan

@DvirDukhan DvirDukhan commented Mar 29, 2022

Copy link
Copy Markdown

No description provided.

chayim
chayim previously approved these changes Mar 30, 2022
View reviewed changes
@codecov-commenter

codecov-commenter commented Mar 30, 2022 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

Merging #2960 (dc9fad7) into master (83af8c1) will decrease coverage by 0.08%.
The diff coverage is 0.00%.

@@             Coverage Diff              @@
##             master    #2960      +/-   ##
============================================
- Coverage     53.74%   53.66%   -0.09%     
+ Complexity     3336     3335       -1     
============================================
  Files           217      217              
  Lines         13288    13294       +6     
  Branches        774      775       +1     
============================================
- Hits           7142     7134       -8     
- Misses         5899     5912      +13     
- Partials        247      248       +1
Impacted Files Coverage Δ
...rc/main/java/redis/clients/jedis/search/Query.java 0.00% <0.00%> (ø)
...ava/redis/clients/jedis/search/SearchProtocol.java 0.00% <0.00%> (ø)
...in/java/redis/clients/jedis/ConnectionFactory.java 63.26% <0.00%> (-4.09%) ⬇️
src/main/java/redis/clients/jedis/Connection.java 83.83% <0.00%> (-1.52%) ⬇️
src/main/java/redis/clients/jedis/Protocol.java 88.12% <0.00%> (-1.25%) ⬇️
src/main/java/redis/clients/jedis/Jedis.java 84.88% <0.00%> (-0.05%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 83af8c1...dc9fad7. Read the comment docs.

sazzad16
sazzad16 suggested changes Mar 30, 2022
View reviewed changes
Comment thread src/test/java/redis/clients/jedis/modules/search/SearchTest.java Resolved
Comment thread src/test/java/redis/clients/jedis/modules/search/SearchTest.java Resolved
Comment thread src/test/java/redis/clients/jedis/modules/search/SearchTest.java Resolved
Comment thread src/test/java/redis/clients/jedis/modules/search/SearchTest.java Resolved
Comment thread src/test/java/redis/clients/jedis/modules/search/SearchTest.java Resolved
Comment thread src/test/java/redis/clients/jedis/modules/search/SearchTest.java Resolved
Comment thread src/test/java/redis/clients/jedis/modules/search/SearchTest.java Resolved
@sazzad16
sazzad16 merged commit 5fa461e into redis:master Mar 31, 2022
@sazzad16 sazzad16 mentioned this pull request Mar 31, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers
@sazzad16 sazzad16 sazzad16 approved these changes
@chayim chayim chayim left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@DvirDukhan @codecov-commenter @chayim @sazzad16