Visitar URL original
Remove implicit clear in `ReadyToRunQueue::drop` by ibraheemdev · Pull Request #2493 · rust-lang/futures-rs · GitHub
Skip to content

Remove implicit clear in ReadyToRunQueue::drop - #2493

Merged
taiki-e merged 2 commits into
rust-lang:masterfrom
ibraheemdev:rtrq-ub
Sep 2, 2021
Merged

taiki-e merged 2 commits into
rust-lang:masterfrom
ibraheemdev:rtrq-ub

Conversation

@ibraheemdev

Copy link
Copy Markdown
Member

Resolves #2473

@ibraheemdev
ibraheemdev requested a review from taiki-e as a code owner September 2, 2021 17:17
@taiki-e

taiki-e commented Sep 2, 2021 •

Copy link
Copy Markdown
Member

Thanks! Could you also update safety docs on ReadyToRunQueue::clear? (FuturesUnordered::clear -> FuturesUnordered::clear_head_all)

// # Safety
//
// - All tasks **must** have had their futures dropped already (by FuturesUnordered::clear)

@taiki-e
taiki-e merged commit 37dfb05 into rust-lang:master Sep 2, 2021
taiki-e pushed a commit that referenced this pull request Nov 23, 2021
@taiki-e taiki-e mentioned this pull request Nov 23, 2021
@taiki-e taiki-e added 0.3-backport: pending The maintainer accepted to backport this to the 0.3 branch, but backport has not been done yet. 0.3-backport: completed and removed 0.3-backport: pending The maintainer accepted to backport this to the 0.3 branch, but backport has not been done yet. labels Nov 23, 2021
taiki-e pushed a commit that referenced this pull request Nov 23, 2021
taiki-e pushed a commit that referenced this pull request Nov 23, 2021
taiki-e added a commit that referenced this pull request Dec 18, 2021
taiki-e added a commit that referenced this pull request Dec 18, 2021
taiki-e added a commit that referenced this pull request Dec 18, 2021
@taiki-e taiki-e mentioned this pull request Dec 18, 2021
taiki-e added a commit that referenced this pull request Dec 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Safety risk with reusing ReadyToRunQueue

2 participants