Visitar URL original
chore: Use default Apline version from docker-node by nschonni · Pull Request #3121 · sass/node-sass · GitHub
Skip to content
This repository was archived by the owner on Jul 24, 2024. It is now read-only.

chore: Use default Apline version from docker-node - #3121

Merged
nschonni merged 3 commits into
masterfrom
nschonni-default-alpine
Jun 2, 2021
Merged

nschonni merged 3 commits into
masterfrom
nschonni-default-alpine

Conversation

@nschonni

Copy link
Copy Markdown
Contributor

Matching the current defaults from https://github.com/nodejs/docker-node/blob/main/versions.json
A bunch of the current defaults are EOL versions of Alpine, so the tags are out of date

@nschonni
nschonni force-pushed the nschonni-default-alpine branch from 6d794f0 to 7e69833 Compare May 31, 2021 18:29
@nschonni
nschonni requested review from saper and xzyfer June 1, 2021 03:30

@xzyfer xzyfer left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm. Can we get by without even specifying the minor?

@nschonni

nschonni commented Jun 1, 2021

Copy link
Copy Markdown
Contributor Author

Yes, there are tags for just plain 16-alpine that could be used. I'm not sure why I chose the previous ones before, but I was thinking it was probably the minimum supported version of Alpine for each Node version.
I'm fine with dropping the version, if this is just aligning it with the default version anyway.

@nschonni
nschonni merged commit cfcbb2c into master Jun 2, 2021
@nschonni
nschonni deleted the nschonni-default-alpine branch June 2, 2021 16:54
xzyfer pushed a commit that referenced this pull request Jun 24, 2021
* chore: Use default Apline version from docker-node

* chore: Add python version to CI matrix

* chore: Use default Alpine image for each version
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants