License comments lined up at the end of .min.js files

I've read the [contribution guidelines][1] and agree with them

I've found a bug and checked that ...

... the problem doesn't occur with the default MkDocs template
... the problem is not in any of my customizations (CSS, JS, template)
... the documentation does not mention anything about my problem
... there are no open or closed issues that are related to my problem

Description

The license comments in bundle.min.js and search.min.js seem oddly placed (at the end of the files, not in-between code blocks), was that an intended change from version 6 to version 7?

Thanks for reporting. It's the default behavior of ESBuild which we're using from v7 on. Honestly, I don't care where they are, so yes, we can move them inline to their respective sources if there are no downsides like increased bundle size after gzip. ESBuild is parametrized here, so feel free to create a PR:

mkdocs-material/tools/build/transform/index.ts

Lines 169 to 176 in 94dd748

    
           return defer(() => esbuild({ 
        
             entryPoints: [options.from], 
        
             target: "es2015", 
        
             write: false, 
        
             bundle: true, 
        
             sourcemap: true, 
        
             minify: process.argv.includes("--optimize") 
        
           }))

Please include a bundle size comparison after gzip into the PR.

Fixed in a4a00af.

Released as part of 7.1.9

Navigation Menu

Repository navigation

License comments lined up at the end of .min.js files #2761

Description

Metadata

Assignees

Labels

Projects

Milestone

Relationships

Development

	return defer(() => esbuild({
	entryPoints: [options.from],
	target: "es2015",
	write: false,
	bundle: true,
	sourcemap: true,
	minify: process.argv.includes("--optimize")
	}))

License comments lined up at the end of .min.js files #2761

Description

Description

Activity

squidfunk commented on Jun 14, 2021

squidfunk commented on Jun 17, 2021

squidfunk commented on Jun 25, 2021

Metadata

Metadata

Assignees

Labels

Projects

Milestone

Relationships

Development

Issue actions