Visitar URL original
Project Validation · Issue #186 · Code-dot-mil/code.mil · GitHub
Skip to content

Project Validation #186

Open
Open

Description

@arichiv-usds

We should validate the JSON before pushing any changes that could break or improperly update project info.

Activity

  1. self-assigned this
    on Mar 27, 2018
  2. jgarber623-gov commented on Mar 27, 2018

    @jgarber623-gov
    Contributor

    Possibly useful links:

  3. arichiv-usds commented on Mar 27, 2018

    @arichiv-usds
    ContributorAuthor

    Nice

  4. jordangov commented on Mar 27, 2018

    @jordangov
    Contributor

    Yeah... FYI, I've talked to Alvand and they'd like to get the schema validation into the API, but it is not there right now. We may want to wait for that versus doing this.

  5. arichiv-usds commented on Mar 27, 2018

    @arichiv-usds
    ContributorAuthor

    Maybe I could add that :-)

  6. arichiv commented on May 29, 2018

    @arichiv
    Contributor
  7. DanielJDufour commented on Dec 7, 2018

    @DanielJDufour

    FYI: We've updated our validator, which you can find here: https://code.gov/about/compliance/inventory-code/validate-schema

    It's built with json-schema-validator-web-component a reusable web component! :-)

  8. seakintruth commented on Jan 31, 2019

    @seakintruth

    Similar to the Code.json Validator it would be helpful to report broken URL links in the Code.json file.

    I put together a google sheets prototype of sorts here:
    https://docs.google.com/spreadsheets/d/13tzylBYFAISHDaN9QOgL-qIj4we0V7X_Jz_pyzKYrxU/edit?usp=sharing

    It publishes a daily report to here:
    https://docs.google.com/spreadsheets/d/e/2PACX-1vQm1kqCv30grzurClLrYTGb3P-itY07Cbl70Hu-7UBEIAKAiz3s8v1y-VFAp4vLqaH3qQ2FVilRSFHb/pubhtml

    This tool attempts to daily import each agency's code.json file as described by the code.gov site and verify pertinent URLs for each agency's code.json file. These verifications are displayed on the UrlStatus worksheet. This report displays the HTTPS response codes when >=300 from a call to Google App Script UrlFetch() for each URL.

    It works as is, but only validates files that are found from the existing agencies code.json files.

  9. jordangov commented on Jan 31, 2019

    @jordangov
    Contributor

    Neat! Have you also posted that to the Code.gov repo?

  10. seakintruth commented on Jan 31, 2019

    @seakintruth
  11. jalbertbowden commented on Mar 8, 2019

    @jalbertbowden

    Curious why Project Validation is only JSON validation? I'm sure it'll fail if JSON doesn't validate, but wondering the emphasis behind this?
    W3C has a linkrot validator, amongst their other validators, that you could use here too:
    https://validator.w3.org/checklink

  12. jordangov commented on Mar 8, 2019

    @jordangov
    Contributor

    Happy to include that as well...

  13. afomi commented on Feb 12, 2020

    @afomi

    Is there more work to be done for this issue?

    It looks like JSON is being validated. If there's more to be validated, perhaps it can be clarified in a new issue.

  14. jordangov commented on Feb 13, 2020

    @jordangov
    Contributor

    The format of the JSON is validated, but not the structure that Code.gov really wants, or the content of the information (like that URLs really are URLs, or that there is a POC).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions