Repository navigation
BannerUrl is always null #2051
Description
Summary
BannerUrl from the DiscordUser class is always null, even if the target has Nitro.
What version of the library are you using?
v5.0.0-nightly (make sure you are using the latest nightly!)
What .NET version are you using? Make sure to use the latest patch release for your major version.
.NET 8.0
Operating System
Windows 11 23H2 (Build 22631.3880)
Reproduction Steps
Get BannerUrl form a DiscordUser
Trace Logs
No response
Exceptions or other error messages
No response
Anything else you'd like to share
No response
Activity
Erisa commentedon Jul 29, 2024
As far as I can tell:
The reason
BannerUrlis null is becauseBannerHashis null - when you read a user from cache without any REST calls, this always seems to be the case. If you force cache the user with e.g.await ctx.Client.GetUserAsync(user.Id, true);then they have a banner hash and URL. So that is one workaround, and indicates the correct data is served by REST.When poking around in Gateway events I got as deep as
DSharpPlus/DSharpPlus/Clients/DiscordClient.Dispatch.cs
Line 39 in a7de2a0
and that
payload, specifically inmembersand in the case of a guild create I tested, also gives null banners (and yes, my user does have a banner):Given how raw this is it would make me think Discord is providing null banner hash entries over gateway that are getting cached? But I don't know how the other gateway logic works enough to know for sure if that's just a red herring or not.
EDIT: In fact, avatar at that stage is
null, so it may indeed be a red herring 🤷♀️SlimeBluKing commentedon Jul 30, 2024
Understood
Naamloos commentedon Jul 31, 2024
Keep this open for now, this could very well be a bug with cache.
Banner and Avatar are optional fields that are not always sent by Discord. It is not unlikely our cache somehow picks this up as "the banner or avatar being removed".
Honestly, this could very well be an issue caused by library "design"
Naamloos commentedon Jul 31, 2024
I am not 100% sure, but since banner and avatar can both either be "absent" or "empty" and the library returns both of these as "null" to the end user, I think it could very well be a cache oopsie
SlimeBluKing commentedon Aug 3, 2024
maybe...