Visitar URL original
fix(install): handle shallow pinned updates by mogul · Pull Request #428 · GSA-TTS/agentic-coding-quickstart · GitHub
Skip to content

fix(install): handle shallow pinned updates - #428

Merged
mogul merged 2 commits into
mainfrom
fix/pr-419-review-findings
Aug 31, 2026
Merged

mogul merged 2 commits into
mainfrom
fix/pr-419-review-findings

Conversation

@mogul

@mogul mogul commented Aug 31, 2026 •

Copy link
Copy Markdown
Contributor

Context

Addresses the non-blocking follow-up findings from the review on #419.

What changed

  • Documented that direct sh install.sh from a source checkout still installs from the configured repository at the default release tag, not from the invoking working tree.
  • Added a shared pinned-SHA checkout helper for clone installs.
  • Fixed existing shallow managed clones so --sha reinstalls fetch advertised heads/tags before failing a pinned commit checkout.
  • Added focused Bats coverage for the existing shallow clone update path.

Verification

  • shellcheck --severity=warning install.sh test/bats/05-install.bats — passed.
  • ./scripts/test-acq-bats test/bats/05-install.bats — passed, 3 tests.
  • npm run lint:md — passed, 0 issues.
  • git diff --check — passed.
  • Live scratch regression with a real shallow tag clone and a later arbitrary commit SHA — passed; installer updated the existing shallow clone to the pinned SHA.

Rollback

Revert this PR. The installer will return to the PR 419 behavior where fresh clone SHA pinning can deepen shallow history but existing shallow managed clones do not have the same fallback.

Security impact

Positive supply-chain correctness impact: existing shallow managed installs now honor pinned commit installs consistently with fresh installs. No authn/authz paths, secret handling, sandbox permissions, or network allowlists are broadened.

AI assistance

AI-assisted implementation with human review required before merge.

@mogul
mogul requested a review from a team as a code owner August 31, 2026 22:44
@mogul
mogul force-pushed the fix/pr-419-review-findings branch from debe53e to 91304bb Compare August 31, 2026 22:47
@mogul
mogul enabled auto-merge (squash) August 31, 2026 22:54
@mogul
mogul disabled auto-merge August 31, 2026 23:28
@mogul
mogul merged commit 2f2eb37 into main Aug 31, 2026
5 checks passed
@mogul
mogul deleted the fix/pr-419-review-findings branch August 31, 2026 23:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant