Visitar URL original
Move processFunctionLogs functions into a library · Issue #1240 · GoogleCloudPlatform/php-docs-samples · GitHub
Skip to content

Move processFunctionLogs functions into a library #1240

Description

@ace-n

I've noticed several (and counting) of our Cloud Functions samples' DeployTests define a processFunctionLogs function.

Since these functions are largely similar (if not the same) across all these files, we should move this logic to a shared library (e.g. php-tools) or a single location within the repo (maybe the root-level testing directory?).

Activity

  1. added
    type: feature request‘Nice-to-have’ improvement, new feature or different behavior or design.
    api: cloudfunctionsIssues related to the Cloud Run functions API.
    on Dec 15, 2020
  2. grayside commented on Jan 6, 2021

    @grayside
    Contributor

    I suggest following the existing pattern and putting this inside the CloudFunctionsDeployTrait or creating a new trait to encapsulate utilities for async testing. When the first example was merged, we discussed that being a useful follow-up as part of the 2nd or 3rd usage to make sure we understood the needed logic.

  3. removed their assignment
    on Jan 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

api: cloudfunctionsIssues related to the Cloud Run functions API.samplesIssues that are directly related to samples.type: feature request‘Nice-to-have’ improvement, new feature or different behavior or design.

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions