Repository navigation
[BUG] JSQLParser 5.3 : PostgreSQL : Cannot parse DROP COLUMN command where data is the column name #2339
Description
Activity
Can confirm adding
tk=<K_DATA>as a case in the drop table identifier fixes thisGreetings.
According to https://manticore-projects.com/JSQLParser/syntax_snapshot.html#alterexpression we only allow
<S_IDENTIFIER> | <S_QUOTED_IDENTIFIER> | "NAME"which excludes any defined token (like<K_DATA>).
The correct way would be to allow forRelObjName(which allows for all tokens that are not reserved keywords).PRs are welcome.
Reacted by William NeedhamThanks for your time!
I can see we recently introduced KeywordOrIdentifier() as part of #2203, which appears to be used in other branches of
alterexpression.Would it be suitable to use that in the DROP branch for consistency and extend to additionally handle the
K_DATAtoken? I have this working with a test case locally and am happy to raise a PR.Although I am aware that continually appending tokens to that may not be ideal and refactoring to use RelObjectName may be preferred
KeywordOrIdentifier()is not sufficient.
You needRelObjectNameinstead.
Failing SQL Feature:
datais the column nameALTER TABLE example DROP COLUMN data;can't be parsedSQL Example:
Software Information:
Tips:
Appears that adding a column with name
dataworks ok