Visitar URL original
CompositeResolver Source Generator · Issue #1699 · MessagePack-CSharp/MessagePack-CSharp · GitHub
Skip to content

CompositeResolver Source Generator #1699

Closed

Description

@neuecc

In particular, in use cases with AOT, the CompositeResolver is essential.
However, there are performance penalties,
such as the need for dictionary lookups every time GetFormatter is called,
as well as issues with unstable behavior in some AOT environments (e.g., Unity's IL2CPP).

How about supporting the generation of CompositeResolver with Source Generators?

[GeneratedMessagePackResolver(typeof(FooGeneated.Instance, StandardResolver.Instance))]
public partial class MyAppResolver;

It would be preferable to reconcile naming conventions and such after #1691.

Activity

  1. added this to the v2.6 milestone on Nov 7, 2023
  2. self-assigned this
    on Jan 24, 2024
  3. added a commit that references this issue on Jan 25, 2024
    d107b85
  4. AArnott commented on Jan 25, 2024

    @AArnott
    Collaborator

    I have the change ready for a PR as soon as #1743 merges (since it builds on that).

  5. added 2 commits that reference this issue on Jan 28, 2024
    70e41ee
    e7adc55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Type

No type

Projects

No projects

    Milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions