Visitar URL original
Update to .NET 8 · Issue #1725 · MessagePack-CSharp/MessagePack-CSharp · GitHub
Skip to content

Update to .NET 8 #1725

Closed
Closed

Activity

  1. pCYSl5EDgo commented on Jan 10, 2024

    @pCYSl5EDgo
    ContributorAuthor

    How to update the problematic package Microsoft.CodeAnalysis.Analyzers to version 3.3.4?
    MessagePack.SourceGenerator/Transforms/*.tt and their generated .cs files have many errors in the v3.3.4.

    There are some options to solve this.

    • Suppress RS1035 in .editorconfig file. <- Easiest
    • Hand rewrite T4 generated code unless T4 team solves the problem. <- Not Good
    • Write netstandard2.0 compatible InterpolatedStringHandler and rewrite the formatters. <- Better but extra work needs
  2. AArnott commented on Jan 10, 2024

    @AArnott
    Collaborator

    I'll have to take a look at this RS1035 issue. FWIW though, I already have a netstandard2.0 compatible interpolated string handler that we could perhaps copy from.

  3. pCYSl5EDgo commented on Jan 10, 2024

    @pCYSl5EDgo
    ContributorAuthor

    Oh! I am glad to hear that. After .NET 8 update, I'll try to make another PR for RS1035 issue unless T4 resolves.

  4. AArnott commented on Jan 10, 2024

    @AArnott
    Collaborator

    I think we should just disable RS1035. At least for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions