Visitar URL original
Comparing main...release/21 · NativeScript/angular · GitHub
Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: NativeScript/angular
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: main
Choose a base ref
...
head repository: NativeScript/angular
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: release/21
Choose a head ref
Checking mergeability… Don’t worry, you can still create the pull request.
  • 8 commits
  • 12 files changed
  • 4 contributors

Commits on Oct 2, 2026

  1. fix: bootstrap NG0210 when the runtime exposes a global PerformanceOb… 

    …server (#178)

Angular's dev-mode ImagePerformanceWarning only bails out early when
PerformanceObserver is missing or both image warnings are disabled.
NativeScript runtimes that ship a Web Performance API now define that
global, so the service proceeds to getDocument() and throws NG0210,
failing every debug boot.

Default IMAGE_CONFIG to disabled for both warnings — NativeScript has no
<img> elements for them to scan. Apps can still override it, since their
own providers are applied after the NativeScript ones.

(cherry picked from commit 6daed00)
    @NathanWalker
    NathanWalker committed Oct 2, 2026
    Configuration menu
    Copy the full SHA
    68b1196 View commit details
    Browse the repository at this point in the history

  2. fix: answer DOM probes on NativeScriptDocument instead of throwing (#176 

    )

* Angular discovers some optional configuration by reading the DOM. The
  CSP_NONCE default factory, for example, evaluates
  `DOCUMENT.body.querySelector('[ngCspNonce]')`. `NativeScriptDocument.body`
  was a hollow object, so the optional chaining in those probes did not help
  and they failed with `body?.querySelector is not a function`. Signal forms
  reach this on the first `[formField]` binding, which crashed every
  signal-form dialog at construction.
* `querySelector`, `querySelectorAll`, `getElementById`,
  `getElementsByTagName` and `getElementsByClassName` now answer "nothing
  found" on the document and on `body`/`head`. `createElement` still throws,
  since constructing real nodes is a caller bug rather than a probe.
* CSP_NONCE is also provided as `null`, as there is no CSP in a NativeScript
  runtime. It has to be a root provider: the root injector resolves
  `providedIn: 'root'` tokens itself before consulting the platform injector,
  so providing it in COMMON_PROVIDERS would have had no effect.

(cherry picked from commit 5a5315d)
    @edusperoni @NathanWalker
    edusperoni authored and NathanWalker committed Oct 2, 2026
    Configuration menu
    Copy the full SHA
    834e10e View commit details
    Browse the repository at this point in the history

  3. fix: emit afterClosed only after the native modal dismissal completes (… 

    …#179)

afterClosed was emitted by a hardcoded 100ms fallback timer while the iOS
dismissal animation (~400ms) was still running, so opening another dialog
from afterClosed failed with "the modal view could not be presented".

The 'closed' state is now driven by core's showModal closeCallback, which
fires once the native dismissal has completed, plus a one-shot 'unloaded'
listener scoped inside it so background-driven unloads can't masquerade as
a close. The timer remains only as a 5s safety net.

Both portal types now share the same show/dismiss path, which also makes
natively-dismissed template dialogs emit afterClosed, and afterOpened is
wired to shownModally (it never fired before).

(cherry picked from commit 1fcbca7)
    @edusperoni @NathanWalker
    edusperoni authored and NathanWalker committed Oct 2, 2026
    Configuration menu
    Copy the full SHA
    7c6c13f View commit details
    Browse the repository at this point in the history

  4. ci: setup release workflow 

    (cherry picked from commit d130ff8)
    @edusperoni @NathanWalker
    edusperoni authored and NathanWalker committed Oct 2, 2026
    Configuration menu
    Copy the full SHA
    2208c49 View commit details
    Browse the repository at this point in the history

  5. ci: allow prerelease publishing and limit android/ios test runs 

    (cherry picked from commit 614d141)
    @edusperoni @NathanWalker
    edusperoni authored and NathanWalker committed Oct 2, 2026
    Configuration menu
    Copy the full SHA
    5f381f4 View commit details
    Browse the repository at this point in the history

  6. ci: publish final 21.x releases to the v21 dist-tag

    @NathanWalker
    NathanWalker committed Oct 2, 2026
    Configuration menu
    Copy the full SHA
    cc4e6c8 View commit details
    Browse the repository at this point in the history

  7. ci: use v21-lts dist-tag and allow publish-only release retries

    @NathanWalker
    NathanWalker committed Oct 2, 2026
    Configuration menu
    Copy the full SHA
    b04ef19 View commit details
    Browse the repository at this point in the history

  8. release: 21.2.0

    @github-actions
    github-actions[bot] committed Oct 2, 2026
    Configuration menu
    Copy the full SHA
    cfbec02 View commit details
    Browse the repository at this point in the history
Loading