Visitar URL original
boolean query parameters are sent capitalized (all=True) · Issue #3519 · PyGithub/PyGithub · GitHub
Skip to content

boolean query parameters are sent capitalized (all=True) #3519

Open

Description

@Bolt4243

Requester.add_parameters_to_url passes Python booleans straight to urllib.parse.urlencode, which renders them capitalized. So get_notifications(all=True) sends all=True instead of all=true. GitHub expects lowercase booleans and ignores the capitalized value, so the parameter has no effect.

PR: #3516

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions