Visitar URL original
PullRequest.create_review_comment accepts invalid start_side value 'side' · Issue #3534 · PyGithub/PyGithub · GitHub
Skip to content

PullRequest.create_review_comment accepts invalid start_side value 'side' #3534

Open

Description

@Bolt4243

PullRequest.create_review_comment validates start_side with:

assert is_undefined(start_side) or start_side in ["LEFT", "RIGHT", "side"], start_side

"side" is a copy/paste typo. The GitHub API only accepts LEFT or RIGHT for start_side, so the library lets an invalid value through (it would be rejected by the API).

Version

main

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions