Repository navigation
Instead of Linting... show which linter is actually slow and still running #1810
Description
We have the simple Linting... indicator via busy_indicator_view.py. Make this more useful by showing which linter is still running, for example mypy.... Maybe flake8, mypy... for multiple linters.
I don't know the exact optics here. ... stands for the animated . thing we have. Typically only one linter is still running and we could just print mypy.... If really multiple linters are slow, either switch back to the simplified Linting... or spell all slow linters out like flake8, mypy....
Activity
[-]Instead of `Linting...` show which linter is actually slow ans still running[/-][+]Instead of `Linting...` show which linter is actually slow and still running[/+]braver commentedon May 25, 2021
I feel like we maybe discussed this before? Dejavu.
Anyway, I think the idea is good. "This thing is slow" is much better of course than "something is slow". We don't want to have multiple "animations" going on in the status bar, but I doubt that happens a lot (or rather, I hope so).
Ideally our view in the status bar is stable, like
linterA(w:1) linterB(e:1)switching seamlessly tolinterA... linterB(e:1)and switching seamlessly tolinterA linterB(e:1). Maybe we should just drop the animation and go for a simple horizontal ellipsis if we're waiting for a linter.kaste commentedon May 25, 2021
Yeah, for now I just wanted to reuse what we have, and we have
active_linter_viewandbusy_indicator_view. Ideally we would have just one. If we have it in one, we face the problem that mypy might be slow but we're actually only showingok, no names at all. etc. So it seems the one thing shows the resultsok,flake(w:1), oreslint?. And the other thing is "hold on, the left thing is probably lying; the result is not up to date".braver commentedon May 25, 2021
Well, we always accept that the status bar lags behind what happens in the editor. In my mind it's a question of how much lag to accept before we update that view to say "our mypy result here is out of date, we're waiting for news", and show
mypy... flake(w:1)kaste commentedon May 25, 2021
In the expanded state
mypy flake(w:1)we can attach something to the name and make itmypy... flake8(w:1), but in the shortokstate I don't see that we should expand toflake mypy...just to go back tookbut rather dook mypy....We use the animation to tell it is a transient, momentary state we're in, a static ellipsis is like our
?something that lasts until the user does something, we lint again; it doesn't go away in just another second.braver commentedon May 25, 2021
Yes, totally agree with everything there 👍🏻