Visitar URL original
fix(front): remove url setter and getter · ThatOpen/engine_components@8be541e · GitHub
Skip to content

Commit 8be541e

Browse files
committed
fix(front): remove url setter and getter
1 parent 5bed53b commit 8be541e

2 files changed

Lines changed: 6 additions & 22 deletions

File tree

‎packages/front/package.json‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
{
22
"name": "@thatopen/components-front",
33
"description": "Collection of frontend tools to author BIM apps.",
4-
"version": "2.3.0-alpha.9",
4+
"version": "2.3.0-alpha.10",
55
"author": "That Open Company",
66
"contributors": [
77
"Antonio Gonzalez Viegas (https://github.com/agviegas)",

‎packages/front/src/fragments/IfcStreamer/index.ts‎

Lines changed: 5 additions & 21 deletions
Original file line numberDiff line numberDiff line change
@@ -80,7 +80,11 @@ export class IfcStreamer extends OBC.Component implements OBC.Disposable {
8080

8181
private _fileDB = new StreamerFileDb();
8282

83-
private _url: string = "";
83+
/**
84+
* The URL of the data source for the streaming service.
85+
* It should be set before using the streaming service. Alternatively, you can use a custom fetch function.
86+
*/
87+
private url: string = "";
8488

8589
private _isDisposing = false;
8690

@@ -104,26 +108,6 @@ export class IfcStreamer extends OBC.Component implements OBC.Disposable {
104108
opacity: 0.5,
105109
});
106110

107-
/**
108-
* The URL of the data source for the streaming service.
109-
* It must be set before using the streaming service.
110-
* If not set, an error will be thrown when trying to access the URL.
111-
*/
112-
get url() {
113-
if (!this._url) {
114-
throw new Error("url must be set before using the streaming service!");
115-
}
116-
return this._url;
117-
}
118-
119-
/**
120-
* Sets the URL of the data source for the streaming service.
121-
* @param value - The new URL to be set.
122-
*/
123-
set url(value: string) {
124-
this._url = value;
125-
}
126-
127111
/**
128112
* The world in which the fragments will be displayed.
129113
* It must be set before using the streaming service.

0 commit comments

Comments
 (0)