Visitar URL original
Bumped all dependencies and modernised CI for Node 20+/22+/24+ · TryGhost/node-sqlite3@a962b72 · GitHub
Skip to content
This repository was archived by the owner on Jul 1, 2026. It is now read-only.

Commit a962b72

Browse files
jonatansbergjonatansberg
committed
Bumped all dependencies and modernised CI for Node 20+/22+/24+
Fixes #1824 — prebuild-install failing on Node 22.14.0 due to N-API version string comparison bug in napi-build-utils < 2.0.0. Dependencies: - prebuild-install: ^7.1.1 -> ^7.1.3 (fixes N-API version detection) - prebuild: 12.1.0 -> 13.0.1 - tar: ^6.1.11 -> ^7.5.10 (fixes 6 HIGH CVEs) - node-addon-api: ^7.0.0 -> ^8.0.0 - node-gyp: 8.x -> 12.x (peer + optional) - Added engines field: node >=20.17.0 - Added yarn.lock CI: - Test matrix: Node 20, 22, 24 (all current LTS lines) - ubuntu-20.04 -> ubuntu-24.04, alpine3.15 -> alpine3.20 - Replaced macos-m1 self-hosted with macos-latest (now ARM64) - Dropped win32-ia32 (Node 24 no longer ships 32-bit Windows) - Excluded macos x64 + Node 20 (Rosetta 2 async hooks bug) - Removed pip install setuptools workaround - Updated actions (checkout v6, setup-node v6, upload-artifact v7, setup-qemu-action v4, setup-buildx-action v4) - Sanitised artifact names to avoid slashes from platform targets - Dockerfile: Node 18 -> 24, bullseye -> bookworm
1 parent 66d054a commit a962b72

7 files changed

Lines changed: 3324 additions & 47 deletions

File tree

‎.github/workflows/ci.yml‎

Lines changed: 38 additions & 35 deletions
Original file line numberDiff line numberDiff line change
@@ -20,39 +20,42 @@ jobs:
2020
matrix:
2121
os:
2222
- macos-latest
23-
- ubuntu-20.04
23+
- ubuntu-24.04
2424
- windows-latest
2525
host:
2626
- x64
2727
target:
2828
- x64
2929
node:
30-
- 18
30+
- 20
31+
- 22
32+
- 24
33+
exclude:
34+
# Node 20 x64 crashes under Rosetta 2 on ARM64 macOS runners
35+
- os: macos-latest
36+
node: 20
37+
host: x64
3138
include:
32-
- os: windows-latest
33-
node: 18
34-
host: x86
35-
target: x86
36-
- os: macos-m1
37-
node: 18
39+
- os: macos-latest
40+
node: 20
3841
host: arm64
3942
target: arm64
40-
name: ${{ matrix.os }} (host=${{ matrix.host }}, target=${{ matrix.target }})
43+
- os: macos-latest
44+
node: 22
45+
host: arm64
46+
target: arm64
47+
- os: macos-latest
48+
node: 24
49+
host: arm64
50+
target: arm64
51+
name: ${{ matrix.os }} (node=${{ matrix.node }}, host=${{ matrix.host }}, target=${{ matrix.target }})
4152
steps:
42-
- uses: actions/checkout@b4ffde65f46336ab88eb53be808477a3936bae11 # v4
43-
- uses: actions/setup-node@v4
53+
- uses: actions/checkout@v6
54+
- uses: actions/setup-node@v6
4455
with:
4556
node-version: ${{ matrix.node }}
4657
architecture: ${{ matrix.host }}
4758

48-
- name: Add yarn (self-hosted)
49-
if: matrix.os == 'macos-m1'
50-
run: npm install -g yarn
51-
52-
- name: Add setuptools for Python 3.12 (temp)
53-
if: matrix.os != 'macos-m1'
54-
run: pip install setuptools
55-
5659
- name: Add msbuild to PATH
5760
uses: microsoft/setup-msbuild@v1.3
5861
if: contains(matrix.os, 'windows')
@@ -98,16 +101,16 @@ jobs:
98101
run: yarn test
99102

100103
- name: Upload binaries to commit artifacts
101-
uses: actions/upload-artifact@v4
102-
if: matrix.node == 18
104+
uses: actions/upload-artifact@v7
105+
if: matrix.node == 24
103106
with:
104-
name: prebuilt-binaries
107+
name: prebuilt-binaries-${{ matrix.os }}-${{ matrix.host }}
105108
path: prebuilds/*
106109
retention-days: 7
107110

108111
- name: Upload binaries to GitHub Release
109112
run: yarn upload --upload-all ${{ github.token }}
110-
if: matrix.node == 18 && startsWith(github.ref, 'refs/tags/')
113+
if: matrix.node == 24 && startsWith(github.ref, 'refs/tags/')
111114

112115
build-qemu:
113116
runs-on: ubuntu-latest
@@ -116,26 +119,26 @@ jobs:
116119
fail-fast: false
117120
matrix:
118121
node:
119-
- 18
122+
- 24
120123
target:
121124
- linux/arm64
122125
variant:
123-
- bullseye
124-
- alpine3.15
126+
- bookworm
127+
- alpine3.20
125128
include:
126129
# musl x64 builds
127130
- target: linux/amd64
128-
variant: alpine3.15
129-
node: 18
131+
variant: alpine3.20
132+
node: 24
130133
name: ${{ matrix.variant }} (node=${{ matrix.node }}, target=${{ matrix.target }})
131134
steps:
132-
- uses: actions/checkout@b4ffde65f46336ab88eb53be808477a3936bae11 # v4
135+
- uses: actions/checkout@v6
133136

134137
- name: Set up QEMU
135-
uses: docker/setup-qemu-action@v3
138+
uses: docker/setup-qemu-action@v4
136139

137140
- name: Setup Docker Buildx
138-
uses: docker/setup-buildx-action@v3
141+
uses: docker/setup-buildx-action@v4
139142

140143
- name: Build binaries and test
141144
run: |
@@ -152,13 +155,13 @@ jobs:
152155
docker cp $CONTAINER_ID:/usr/src/build/prebuilds/ ./prebuilds
153156
154157
- name: Upload binaries to commit artifacts
155-
uses: actions/upload-artifact@v4
156-
if: matrix.node == 18
158+
uses: actions/upload-artifact@v7
159+
if: matrix.node == 24
157160
with:
158-
name: prebuilt-binaries
161+
name: prebuilt-binaries-${{ matrix.variant }}-${{ matrix.target == 'linux/arm64' && 'linux-arm64' || 'linux-amd64' }}
159162
path: prebuilds/*
160163
retention-days: 7
161164

162165
- name: Upload binaries to GitHub Release
163166
run: yarn install --ignore-scripts && yarn upload --upload-all ${{ github.token }}
164-
if: matrix.node == 18 && startsWith(github.ref, 'refs/tags/')
167+
if: matrix.node == 24 && startsWith(github.ref, 'refs/tags/')

‎.gitignore‎

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -28,5 +28,4 @@ setup.sh
2828
/build-tmp-napi-v6
2929
*.tgz
3030
package-lock.json
31-
yarn.lock
3231
prebuilds

‎README.md‎

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -36,7 +36,7 @@ yarn add sqlite3
3636

3737
### Prebuilt binaries
3838

39-
`sqlite3` v5+ was rewritten to use [Node-API](https://nodejs.org/api/n-api.html) so prebuilt binaries do not need to be built for specific Node versions. `sqlite3` currently builds for both Node-API v3 and v6. Check the [Node-API version matrix](https://nodejs.org/api/n-api.html#node-api-version-matrix) to ensure your Node version supports one of these. The prebuilt binaries should be supported on Node v10+.
39+
`sqlite3` v5+ was rewritten to use [Node-API](https://nodejs.org/api/n-api.html) so prebuilt binaries do not need to be built for specific Node versions. `sqlite3` currently builds for both Node-API v3 and v6. Check the [Node-API version matrix](https://nodejs.org/api/n-api.html#node-api-version-matrix) to ensure your Node version supports one of these. The prebuilt binaries should be supported on Node v20.17.0+.
4040

4141
The module uses [`prebuild-install`](https://github.com/prebuild/prebuild-install) to download the prebuilt binary for your platform, if it exists. These binaries are hosted on GitHub Releases for `sqlite3` versions above 5.0.2, and they are hosted on S3 otherwise. The following targets are currently provided:
4242

@@ -46,7 +46,6 @@ The module uses [`prebuild-install`](https://github.com/prebuild/prebuild-instal
4646
* `linux-x64`
4747
* `linuxmusl-arm64`
4848
* `linuxmusl-x64`
49-
* `win32-ia32`
5049
* `win32-x64`
5150

5251
Unfortunately, [prebuild](https://github.com/prebuild/prebuild/issues/174) cannot differentiate between `armv6` and `armv7`, and instead uses `arm` as the `{arch}`. Until that is fixed, you will still need to install `sqlite3` from [source](#source-install).

‎package.json‎

Lines changed: 9 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -45,25 +45,28 @@
4545
},
4646
"dependencies": {
4747
"bindings": "^1.5.0",
48-
"node-addon-api": "^7.0.0",
49-
"prebuild-install": "^7.1.1",
50-
"tar": "^6.1.11"
48+
"node-addon-api": "^8.0.0",
49+
"prebuild-install": "^7.1.3",
50+
"tar": "^7.5.10"
5151
},
5252
"devDependencies": {
5353
"eslint": "8.56.0",
5454
"mocha": "10.2.0",
55-
"prebuild": "12.1.0"
55+
"prebuild": "13.0.1"
5656
},
5757
"peerDependencies": {
58-
"node-gyp": "8.x"
58+
"node-gyp": "12.x"
5959
},
6060
"peerDependenciesMeta": {
6161
"node-gyp": {
6262
"optional": true
6363
}
6464
},
6565
"optionalDependencies": {
66-
"node-gyp": "8.x"
66+
"node-gyp": "12.x"
67+
},
68+
"engines": {
69+
"node": ">=20.17.0"
6770
},
6871
"scripts": {
6972
"install": "prebuild-install -r napi || node-gyp rebuild",

‎tools/BinaryBuilder.Dockerfile‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
1-
ARG NODE_VERSION=18
2-
ARG VARIANT=bullseye
1+
ARG NODE_VERSION=24
2+
ARG VARIANT=bookworm
33

44
FROM node:$NODE_VERSION-$VARIANT
55

‎tools/semver-check.js‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@ const fs = require('fs');
22
const path = require('path');
33
const semver = require('semver');
44

5-
const supportedVersions = '10.12.0';
5+
const supportedVersions = '20.17.0';
66

77
function checkEngines(modulePath) {
88
const packageJsonPath = path.join(modulePath, 'package.json');

0 commit comments

Comments
 (0)