Visitar URL original
"no-unresolved" flagged for import of `csv-stringify` · Issue #372 · adaltas/node-csv · GitHub
Skip to content

"no-unresolved" flagged for import of csv-stringify #372

Open

Description

@himynameisdave

Describe the bug

Not exactly a bug because it's not truly blocking me and I'm sure it's got something to do with my environment, but wanted to post here to help figure it out.

Basically I've upgraded to the latest version of this package and updated my imports to 'csv-stringify/sync', but my editor is flagging it as an unresolved dependency (even tho they path is resolved when I hover it). Everything seems to work fine, it's just annoying that this is being flagged.

Using TypeScript here as well, if that is relevant.

To Reproduce

  • Updated csv-stringify from 5.6.5 to 6.2.3
  • Change imports from...
    import * as stringify from 'csv-stringify/lib/sync';
    
    ...to...
    import { stringify } from 'csv-stringify/sync';
    

Additional context

image

Activity

  1. wdavidw commented on Dec 1, 2022

    @wdavidw
    Member

    I am no export in the TS field, anyone ?

  2. nwalters512 commented on Jan 12, 2023

    @nwalters512

    This is because this package now uses exports to declare what files are available, and eslint-plugin-import doesn't yet support that: import-js/eslint-plugin-import#1810.

    Adding a file sync.js or sync/index.js to the published version of these packages would resolve this.

  3. karlhorky commented on Aug 25, 2023

    @karlhorky

    Hm, I just tried upgrading to csv@6.3.2 (which also includes the changes from #397) and I no longer need an ESLint disable for import/no-unresolved (not sure if this was caused by this change or some other earlier change) - can anyone else confirm that this is fixed now?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions