Visitar URL original
Adds flush to metal screenshotter. (#183758) · ahmedsameha1/flutter@0fc5269 · GitHub
Skip to content

Commit 0fc5269

Browse files
gaaclarkeahmedsameha1
authored andcommitted
Adds flush to metal screenshotter. (flutter#183758)
fixes: flutter#183746 ## Pre-launch Checklist - [x] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [x] I read the [AI contribution guidelines] and understand my responsibilities, or I am not using AI tools. - [x] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [x] I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement]. - [x] I signed the [CLA]. - [x] I listed at least one issue that this PR fixes in the description above. - [x] I updated/added relevant documentation (doc comments with `///`). - [x] I added new tests to check the change I am making, or this PR is [test-exempt]. - [x] I followed the [breaking change policy] and added [Data Driven Fixes] where supported. - [x] All existing and new tests are passing. If you need help, consider asking for advice on the #hackers-new channel on [Discord]. **Note**: The Flutter team is currently trialing the use of [Gemini Code Assist for GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code). Comments from the `gemini-code-assist` bot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed. <!-- Links --> [Contributor Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview [AI contribution guidelines]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#ai-contribution-guidelines [Tree Hygiene]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md [test-exempt]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests [Flutter Style Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md [Features we expect every widget to implement]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement [CLA]: https://cla.developers.google.com/ [flutter/tests]: https://github.com/flutter/tests [breaking change policy]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes [Discord]: https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md [Data Driven Fixes]: https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
1 parent f181a12 commit 0fc5269

1 file changed

Lines changed: 15 additions & 1 deletion

File tree

‎engine/src/flutter/impeller/golden_tests/metal_screenshotter.mm‎

Lines changed: 15 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,6 +8,7 @@
88
#include "impeller/renderer/backend/metal/context_mtl.h"
99
#include "impeller/renderer/backend/metal/texture_mtl.h"
1010
#define GLFW_INCLUDE_NONE
11+
#include "flutter/fml/synchronization/waitable_event.h"
1112
#include "third_party/glfw/include/GLFW/glfw3.h"
1213

1314
namespace impeller {
@@ -22,6 +23,20 @@
2223
AiksContext& aiks_context,
2324
const std::shared_ptr<Texture> texture) {
2425
@autoreleasepool {
26+
std::shared_ptr<Context> context = aiks_context.GetContext();
27+
fml::AutoResetWaitableEvent latch;
28+
if (auto cmd_buffer = context->CreateCommandBuffer()) {
29+
if (context->GetCommandQueue()
30+
->Submit({cmd_buffer},
31+
[&latch](CommandBuffer::Status status) {
32+
FML_CHECK(status == CommandBuffer::Status::kCompleted);
33+
latch.Signal();
34+
})
35+
.ok()) {
36+
latch.Wait();
37+
}
38+
}
39+
2540
id<MTLTexture> metal_texture =
2641
std::static_pointer_cast<TextureMTL>(texture)->GetMTLTexture();
2742

@@ -32,7 +47,6 @@
3247
CGColorSpaceRelease(color_space);
3348
FML_CHECK(ciImage);
3449

35-
std::shared_ptr<Context> context = playground_->GetContext();
3650
std::shared_ptr<ContextMTL> context_mtl =
3751
std::static_pointer_cast<ContextMTL>(context);
3852
CIContext* cicontext =

0 commit comments

Comments
 (0)