Repository navigation
Commit 6489ca5
fix(router): reject duplicate outlets in production builds
A URL group that consumes no segments is matched against the same config as
its parent, so a route can match once for every group the URL nests. Every
match lands in one sibling list, which the router cannot activate because
only one of them can own the outlet.
The check that rejects this ran only in development, and never covered the
siblings `mergeEmptyPathMatches` produces. Run it on every list the merge
returns instead.
Fixes #709971 parent 4bc11a5 commit 6489ca5
3 files changed
Lines changed: 43 additions & 7 deletions
File tree
- packages
- core/test/bundling/router
- router
- src
- test
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
452 | 452 | | |
453 | 453 | | |
454 | 454 | | |
| 455 | + | |
455 | 456 | | |
456 | 457 | | |
457 | 458 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
228 | 228 | | |
229 | 229 | | |
230 | 230 | | |
231 | | - | |
232 | | - | |
233 | | - | |
234 | | - | |
235 | | - | |
236 | 231 | | |
237 | 232 | | |
238 | 233 | | |
| |||
585 | 580 | | |
586 | 581 | | |
587 | 582 | | |
588 | | - | |
| 583 | + | |
| 584 | + | |
| 585 | + | |
589 | 586 | | |
590 | 587 | | |
591 | 588 | | |
592 | | - | |
| 589 | + | |
593 | 590 | | |
594 | 591 | | |
595 | 592 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1179 | 1179 | | |
1180 | 1180 | | |
1181 | 1181 | | |
| 1182 | + | |
| 1183 | + | |
| 1184 | + | |
| 1185 | + | |
| 1186 | + | |
| 1187 | + | |
| 1188 | + | |
| 1189 | + | |
| 1190 | + | |
| 1191 | + | |
| 1192 | + | |
| 1193 | + | |
| 1194 | + | |
| 1195 | + | |
| 1196 | + | |
| 1197 | + | |
| 1198 | + | |
| 1199 | + | |
| 1200 | + | |
| 1201 | + | |
| 1202 | + | |
| 1203 | + | |
| 1204 | + | |
| 1205 | + | |
| 1206 | + | |
| 1207 | + | |
| 1208 | + | |
| 1209 | + | |
| 1210 | + | |
| 1211 | + | |
| 1212 | + | |
| 1213 | + | |
| 1214 | + | |
| 1215 | + | |
| 1216 | + | |
| 1217 | + | |
| 1218 | + | |
| 1219 | + | |
1182 | 1220 | | |
1183 | 1221 | | |
1184 | 1222 | | |
| |||
0 commit comments