Repository navigation
Commit d23932f
committed
fix(router): set initial blocking resource input synchronously on activation
When a blocking router resource is bound to a component input via
withComponentInputBinding(), createResourceOutletBindingEffects() previously
only registered an effect() with componentRef.injector. Because the routed
component is instantiated before bindActivatedRouteToOutletComponent() runs,
any effect() created in the component constructor (such as Signal Forms'
form() field management effect) was registered on the view before the
router's binding effect, and lifecycle hooks (ngOnChanges, ngOnInit,
ngDoCheck) also ran before view effects on the initial render. Accessing a
required input or model in those constructor effects or hooks threw NG0950 /
NG0952 on first render.
Set the resolved blocking resource value synchronously via
componentRef.setInput() upon activation while keeping the effect on
componentRef.injector for subsequent reactive updates and error boundary
propagation.
Fixes #70974
(cherry picked from commit 3c13074)1 parent 0ecaf8e commit d23932f
2 files changed
Lines changed: 64 additions & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
21 | 21 | | |
22 | 22 | | |
23 | 23 | | |
| 24 | + | |
24 | 25 | | |
25 | 26 | | |
26 | 27 | | |
| |||
200 | 201 | | |
201 | 202 | | |
202 | 203 | | |
| 204 | + | |
203 | 205 | | |
204 | 206 | | |
205 | 207 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
7 | 7 | | |
8 | 8 | | |
9 | 9 | | |
10 | | - | |
| 10 | + | |
| 11 | + | |
| 12 | + | |
| 13 | + | |
| 14 | + | |
| 15 | + | |
| 16 | + | |
| 17 | + | |
| 18 | + | |
| 19 | + | |
| 20 | + | |
| 21 | + | |
11 | 22 | | |
12 | 23 | | |
13 | 24 | | |
| |||
652 | 663 | | |
653 | 664 | | |
654 | 665 | | |
| 666 | + | |
| 667 | + | |
| 668 | + | |
| 669 | + | |
| 670 | + | |
| 671 | + | |
| 672 | + | |
| 673 | + | |
| 674 | + | |
| 675 | + | |
| 676 | + | |
| 677 | + | |
| 678 | + | |
| 679 | + | |
| 680 | + | |
| 681 | + | |
| 682 | + | |
| 683 | + | |
| 684 | + | |
| 685 | + | |
| 686 | + | |
| 687 | + | |
| 688 | + | |
| 689 | + | |
| 690 | + | |
| 691 | + | |
| 692 | + | |
| 693 | + | |
| 694 | + | |
| 695 | + | |
| 696 | + | |
| 697 | + | |
| 698 | + | |
| 699 | + | |
| 700 | + | |
| 701 | + | |
| 702 | + | |
| 703 | + | |
| 704 | + | |
| 705 | + | |
| 706 | + | |
| 707 | + | |
| 708 | + | |
| 709 | + | |
| 710 | + | |
| 711 | + | |
| 712 | + | |
| 713 | + | |
| 714 | + | |
| 715 | + | |
655 | 716 | | |
656 | 717 | | |
657 | 718 | | |
| |||
0 commit comments