Visitar URL original
fix(datepicker): Don't parse the date twice by realityking · Pull Request #3682 · angular-ui/bootstrap · GitHub
Skip to content
This repository was archived by the owner on May 29, 2019. It is now read-only.

fix(datepicker): Don't parse the date twice - #3682

Closed
realityking wants to merge 1 commit into
angular-ui:masterfrom
realityking:fixdate
Closed

realityking wants to merge 1 commit into
angular-ui:masterfrom
realityking:fixdate

Conversation

@realityking

Copy link
Copy Markdown
Contributor

Fixes #3644, #3617

Potentially fixes #3643 as well, but I haven't tested that one yet.

Unit tests are missing, as I'm at a loss how to test these issues with karma. I'd appreciate some pointers in this regard. If it's fine to add protractor tests, I'd be happy to do so.

@kelvinatorr

Copy link
Copy Markdown

Works for me. Thanks!

@rvanbaalen rvanbaalen added this to the 0.13.1 (Performance) milestone Jun 2, 2015
@rvanbaalen

Copy link
Copy Markdown
Contributor

Looks good and seems to be fixing some problems. Thanks for the PR! Will look into this soon to merge it.

@rvanbaalen

Copy link
Copy Markdown
Contributor

@realityking Can you please add some tests for this?

@realityking

Copy link
Copy Markdown
Contributor Author

@rvanbaalen Just to clarify, these tests would need protractor. Is that ok?

@rvanbaalen

Copy link
Copy Markdown
Contributor

My bad. Now I see your comment about Karma tests. Was running an hour of slightly brainless PR and Issue triaging 😉

@realityking

Copy link
Copy Markdown
Contributor Author

No problem, but I still don't have an answer ;) Are protactor tests fine?

@morgenes

morgenes commented Jun 8, 2015

Copy link
Copy Markdown

+1

@wesleycho

Copy link
Copy Markdown
Contributor

This change would have an effect on HTML5 date inputs I believe, since the $viewChangeListener is the only callback that gets fired that parses the date input.

Can you produce a Plunker with an example of this in action for that situation?

@Blackbaud-PatrickOFriel

Copy link
Copy Markdown
Contributor

Any word on the status of this PR?

@realityking

Copy link
Copy Markdown
Contributor Author

I haven't had time to set up protractor tests, so at least that's still open.

I'd be great if someone could create the test mentioned by @wesleycho as I'm pretty short on time right now.

@almeidap

Copy link
Copy Markdown

I can confirm that this fixes some parsing and validation issues (particularly #1289), specially when manually changing the date.

For those using Bower who would like a hotfix, you may fetch AngularUI from here (minified version not updated): https://github.com/almeidap/angular-ui-bootstrap

@RobJacobs RobJacobs mentioned this pull request Jul 22, 2015
@wesleycho wesleycho modified the milestones: 0.13.1 (npm), 0.13.2 (Performance) Jul 23, 2015
@wesleycho wesleycho closed this in ab4580f Aug 1, 2015
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Datepicker has trouble with some dates datepicker 0.13.0 does not allow model updates after a parse error for certain dates when ng-model-options updateOn: blur is used

10 participants