Repository navigation
Expand file tree
/
Copy pathtransaction_test.go
More file actions
578 lines (488 loc) · 16.7 KB
/
Copy pathtransaction_test.go
File metadata and controls
578 lines (488 loc) · 16.7 KB
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
536
537
538
539
540
541
542
543
544
545
546
547
548
549
550
551
552
553
554
555
556
557
558
559
560
561
562
563
564
565
566
567
568
569
570
571
572
573
574
575
576
577
578
// Licensed to the Apache Software Foundation (ASF) under one
// or more contributor license agreements. See the NOTICE file
// distributed with this work for additional information
// regarding copyright ownership. The ASF licenses this file
// to you under the Apache License, Version 2.0 (the
// "License"); you may not use this file except in compliance
// with the License. You may obtain a copy of the License at
//
// http://www.apache.org/licenses/LICENSE-2.0
//
// Unless required by applicable law or agreed to in writing,
// software distributed under the License is distributed on an
// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
// KIND, either express or implied. See the License for the
// specific language governing permissions and limitations
// under the License.
package casbin
import (
"context"
"errors"
"testing"
"github.com/casbin/casbin/v3/model"
"github.com/casbin/casbin/v3/persist"
)
// MockTransactionalAdapter implements TransactionalAdapter interface for testing.
type MockTransactionalAdapter struct {
Enforcer *Enforcer
}
// MockTransactionContext implements TransactionContext interface for testing.
type MockTransactionContext struct {
adapter *MockTransactionalAdapter
committed bool
rolledBack bool
}
// NewMockTransactionalAdapter creates a new mock adapter.
func NewMockTransactionalAdapter() *MockTransactionalAdapter {
return &MockTransactionalAdapter{}
}
// LoadPolicy implements Adapter interface.
func (a *MockTransactionalAdapter) LoadPolicy(model model.Model) error {
return nil
}
// SavePolicy implements Adapter interface.
func (a *MockTransactionalAdapter) SavePolicy(model model.Model) error {
return nil
}
// AddPolicy implements Adapter interface.
func (a *MockTransactionalAdapter) AddPolicy(sec string, ptype string, rule []string) error {
return nil
}
// RemovePolicy implements Adapter interface.
func (a *MockTransactionalAdapter) RemovePolicy(sec string, ptype string, rule []string) error {
return nil
}
// RemoveFilteredPolicy implements Adapter interface.
func (a *MockTransactionalAdapter) RemoveFilteredPolicy(sec string, ptype string, fieldIndex int, fieldValues ...string) error {
return nil
}
// BeginTransaction implements TransactionalAdapter interface.
func (a *MockTransactionalAdapter) BeginTransaction(ctx context.Context) (persist.TransactionContext, error) {
return &MockTransactionContext{adapter: a}, nil
}
// Commit implements TransactionContext interface.
func (tx *MockTransactionContext) Commit() error {
if tx.committed || tx.rolledBack {
return errors.New("transaction already finished")
}
tx.committed = true
return nil
}
// Rollback implements TransactionContext interface.
func (tx *MockTransactionContext) Rollback() error {
if tx.committed || tx.rolledBack {
return errors.New("transaction already finished")
}
tx.rolledBack = true
return nil
}
// GetAdapter implements TransactionContext interface.
func (tx *MockTransactionContext) GetAdapter() persist.Adapter {
return tx.adapter
}
// Test basic transaction functionality.
func TestTransactionBasicOperations(t *testing.T) {
adapter := NewMockTransactionalAdapter()
e, err := NewTransactionalEnforcer("examples/rbac_model.conf", adapter)
if err != nil {
t.Fatalf("Failed to create transactional enforcer: %v", err)
}
adapter.Enforcer = e.Enforcer
ctx := context.Background()
// Begin transaction.
tx, err := e.BeginTransaction(ctx)
if err != nil {
t.Fatalf("Failed to begin transaction: %v", err)
}
// Add policies in transaction.
ok, err := tx.AddPolicy("alice", "data1", "read")
if !ok || err != nil {
t.Fatalf("Failed to add policy in transaction: %v", err)
}
ok, err = tx.AddPolicy("bob", "data2", "write")
if !ok || err != nil {
t.Fatalf("Failed to add policy in transaction: %v", err)
}
// Commit transaction.
if err := tx.Commit(); err != nil {
t.Fatalf("Failed to commit transaction: %v", err)
}
// Verify transaction was committed.
if !tx.IsCommitted() {
t.Error("Transaction should be committed")
}
}
// Test transaction rollback.
func TestTransactionRollback(t *testing.T) {
adapter := NewMockTransactionalAdapter()
e, err := NewTransactionalEnforcer("examples/rbac_model.conf", adapter)
if err != nil {
t.Fatalf("Failed to create transactional enforcer: %v", err)
}
adapter.Enforcer = e.Enforcer
ctx := context.Background()
// Begin transaction.
tx, err := e.BeginTransaction(ctx)
if err != nil {
t.Fatalf("Failed to begin transaction: %v", err)
}
// Add policy in transaction.
ok, err := tx.AddPolicy("alice", "data1", "read")
if !ok || err != nil {
t.Fatalf("Failed to add policy in transaction: %v", err)
}
// Rollback transaction.
if err := tx.Rollback(); err != nil {
t.Fatalf("Failed to rollback transaction: %v", err)
}
// Verify transaction was rolled back.
if !tx.IsRolledBack() {
t.Error("Transaction should be rolled back")
}
}
// Test concurrent transactions.
func TestConcurrentTransactions(t *testing.T) {
adapter := NewMockTransactionalAdapter()
e, err := NewTransactionalEnforcer("examples/rbac_model.conf", adapter)
if err != nil {
t.Fatalf("Failed to create transactional enforcer: %v", err)
}
adapter.Enforcer = e.Enforcer
ctx := context.Background()
// Start first transaction
tx1, err := e.BeginTransaction(ctx)
if err != nil {
t.Fatalf("Failed to begin transaction 1: %v", err)
}
// Add policy in first transaction
ok, err := tx1.AddPolicy("alice", "data1", "read")
if !ok || err != nil {
t.Fatalf("Failed to add policy in transaction 1: %v", err)
}
// Start second transaction
tx2, err := e.BeginTransaction(ctx)
if err != nil {
t.Fatalf("Failed to begin transaction 2: %v", err)
}
// Add different policy in second transaction
ok, err = tx2.AddPolicy("bob", "data2", "write")
if !ok || err != nil {
t.Fatalf("Failed to add policy in transaction 2: %v", err)
}
// Commit first transaction
if err := tx1.Commit(); err != nil {
t.Fatalf("Failed to commit transaction 1: %v", err)
}
// Commit second transaction
if err := tx2.Commit(); err != nil {
t.Fatalf("Failed to commit transaction 2: %v", err)
}
// Verify transactions were committed
if !tx1.IsCommitted() {
t.Error("Transaction 1 should be committed")
}
if !tx2.IsCommitted() {
t.Error("Transaction 2 should be committed")
}
}
// Test transaction conflicts.
func TestTransactionConflicts(t *testing.T) {
adapter := NewMockTransactionalAdapter()
e, err := NewTransactionalEnforcer("examples/rbac_model.conf", adapter)
if err != nil {
t.Fatalf("Failed to create transactional enforcer: %v", err)
}
adapter.Enforcer = e.Enforcer
ctx := context.Background()
// Test Case 1: Two transactions commit
t.Run("TwoTransactionsCommit", func(t *testing.T) {
tx1, _ := e.BeginTransaction(ctx)
tx2, _ := e.BeginTransaction(ctx)
// Commit both transactions
if err := tx1.Commit(); err != nil {
t.Fatalf("Failed to commit tx1: %v", err)
}
if err := tx2.Commit(); err != nil {
t.Fatalf("Failed to commit tx2: %v", err)
}
// Verify both transactions were committed
if !tx1.IsCommitted() {
t.Error("Transaction 1 should be committed")
}
if !tx2.IsCommitted() {
t.Error("Transaction 2 should be committed")
}
})
// Test Case 2: Transaction rollback
t.Run("TransactionRollback", func(t *testing.T) {
tx, _ := e.BeginTransaction(ctx)
// Rollback transaction
if err := tx.Rollback(); err != nil {
t.Fatalf("Failed to rollback transaction: %v", err)
}
// Verify transaction was rolled back
if !tx.IsRolledBack() {
t.Error("Transaction should be rolled back")
}
})
// Test Case 3: Cannot commit after rollback
t.Run("NoCommitAfterRollback", func(t *testing.T) {
tx, _ := e.BeginTransaction(ctx)
// Rollback transaction
if err := tx.Rollback(); err != nil {
t.Fatalf("Failed to rollback transaction: %v", err)
}
// Try to commit
if err := tx.Commit(); err == nil {
t.Error("Should not be able to commit after rollback")
}
})
}
// Test transaction buffer operations.
func TestTransactionBuffer(t *testing.T) {
adapter := NewMockTransactionalAdapter()
e, err := NewTransactionalEnforcer("examples/rbac_model.conf", adapter)
if err != nil {
t.Fatalf("Failed to create transactional enforcer: %v", err)
}
adapter.Enforcer = e.Enforcer
ctx := context.Background()
tx, err := e.BeginTransaction(ctx)
if err != nil {
t.Fatalf("Failed to begin transaction: %v", err)
}
// Initially no operations.
if tx.HasOperations() {
t.Fatal("Transaction should have no operations initially")
}
if tx.OperationCount() != 0 {
t.Fatal("Operation count should be 0 initially")
}
// Add some operations.
tx.AddPolicy("alice", "data1", "read")
tx.AddPolicy("bob", "data2", "write")
if !tx.HasOperations() {
t.Fatal("Transaction should have operations")
}
if tx.OperationCount() != 2 {
t.Fatalf("Expected 2 operations, got %d", tx.OperationCount())
}
// Get buffered model.
bufferedModel, err := tx.GetBufferedModel()
if err != nil {
t.Fatalf("Failed to get buffered model: %v", err)
}
// Check that buffered model contains the policies.
hasPolicy, _ := bufferedModel.HasPolicy("p", "p", []string{"alice", "data1", "read"})
if !hasPolicy {
t.Fatal("Buffered model should contain the added policy")
}
tx.Rollback()
}
// newTestTransactionalEnforcer creates a transactional enforcer backed by the mock adapter.
func newTestTransactionalEnforcer(t *testing.T) *TransactionalEnforcer {
t.Helper()
adapter := NewMockTransactionalAdapter()
e, err := NewTransactionalEnforcer("examples/rbac_model.conf", adapter)
if err != nil {
t.Fatalf("Failed to create transactional enforcer: %v", err)
}
adapter.Enforcer = e.Enforcer
return e
}
// hasPolicy reports whether the enforcer model holds the given policy rule.
func hasPolicy(t *testing.T, e *TransactionalEnforcer, params ...interface{}) bool {
t.Helper()
ok, err := e.HasPolicy(params...)
if err != nil {
t.Fatalf("Failed to check policy %v: %v", params, err)
}
return ok
}
// hasGroupingPolicy reports whether the enforcer model holds the given grouping policy rule.
func hasGroupingPolicy(t *testing.T, e *TransactionalEnforcer, params ...interface{}) bool {
t.Helper()
ok, err := e.HasGroupingPolicy(params...)
if err != nil {
t.Fatalf("Failed to check grouping policy %v: %v", params, err)
}
return ok
}
// Test batch grouping policy operations within a transaction.
func TestTransactionGroupingPolicies(t *testing.T) {
e := newTestTransactionalEnforcer(t)
ctx := context.Background()
err := e.WithTransaction(ctx, func(tx *Transaction) error {
if ok, err := tx.AddPolicy("admin", "data1", "read"); !ok || err != nil {
t.Fatalf("Failed to add policy in transaction: %v", err)
}
if ok, err := tx.AddGroupingPolicies([][]string{{"alice", "admin"}, {"bob", "admin"}}); !ok || err != nil {
t.Fatalf("Failed to add grouping policies in transaction: %v", err)
}
return nil
})
if err != nil {
t.Fatalf("Failed to commit transaction: %v", err)
}
if !hasGroupingPolicy(t, e, "alice", "admin") || !hasGroupingPolicy(t, e, "bob", "admin") {
t.Fatal("Both grouping policies should have been added")
}
// Role links must have been rebuilt for the committed grouping policies.
if allowed, enforceErr := e.Enforce("alice", "data1", "read"); enforceErr != nil || !allowed {
t.Fatalf("alice should inherit the admin permission, got %v (err %v)", allowed, enforceErr)
}
// Removing them again must take effect too.
err = e.WithTransaction(ctx, func(tx *Transaction) error {
removed, removeErr := tx.RemoveGroupingPolicies([][]string{{"alice", "admin"}, {"bob", "admin"}})
if !removed || removeErr != nil {
t.Fatalf("Failed to remove grouping policies in transaction: %v", removeErr)
}
return nil
})
if err != nil {
t.Fatalf("Failed to commit transaction: %v", err)
}
if hasGroupingPolicy(t, e, "alice", "admin") || hasGroupingPolicy(t, e, "bob", "admin") {
t.Fatal("Both grouping policies should have been removed")
}
if ok, _ := e.Enforce("alice", "data1", "read"); ok {
t.Fatal("alice should no longer inherit the admin permission")
}
}
// Test updating a grouping policy within a transaction.
func TestTransactionUpdateGroupingPolicy(t *testing.T) {
e := newTestTransactionalEnforcer(t)
ctx := context.Background()
if err := e.WithTransaction(ctx, func(tx *Transaction) error {
_, err := tx.AddGroupingPolicy("alice", "admin")
return err
}); err != nil {
t.Fatalf("Failed to commit transaction: %v", err)
}
// Updating a rule that does not exist changes nothing.
if err := e.WithTransaction(ctx, func(tx *Transaction) error {
ok, err := tx.UpdateGroupingPolicy([]string{"carol", "admin"}, []string{"carol", "user"})
if err != nil {
return err
}
if ok {
t.Fatal("Updating a missing grouping policy should return false")
}
return nil
}); err != nil {
t.Fatalf("Failed to commit transaction: %v", err)
}
// Mismatched batch lengths are rejected.
if err := e.WithTransaction(ctx, func(tx *Transaction) error {
if _, err := tx.UpdateGroupingPolicies([][]string{{"alice", "admin"}}, [][]string{}); err == nil {
t.Fatal("Mismatched old/new rule counts should return an error")
}
return nil
}); err != nil {
t.Fatalf("Failed to commit transaction: %v", err)
}
if err := e.WithTransaction(ctx, func(tx *Transaction) error {
ok, err := tx.UpdateGroupingPolicy([]string{"alice", "admin"}, []string{"alice", "user"})
if !ok || err != nil {
t.Fatalf("Failed to update grouping policy in transaction: %v", err)
}
return nil
}); err != nil {
t.Fatalf("Failed to commit transaction: %v", err)
}
if hasGroupingPolicy(t, e, "alice", "admin") {
t.Fatal("The old grouping policy should have been removed")
}
if !hasGroupingPolicy(t, e, "alice", "user") {
t.Fatal("The new grouping policy should have been added")
}
}
// Test filtered removal within a transaction.
func TestTransactionRemoveFilteredPolicy(t *testing.T) {
e := newTestTransactionalEnforcer(t)
ctx := context.Background()
if err := e.WithTransaction(ctx, func(tx *Transaction) error {
if _, err := tx.AddPolicies([][]string{
{"alice", "data1", "read"},
{"alice", "data2", "write"},
{"bob", "data2", "write"},
}); err != nil {
return err
}
_, err := tx.AddGroupingPolicies([][]string{{"alice", "admin"}, {"bob", "admin"}})
return err
}); err != nil {
t.Fatalf("Failed to commit transaction: %v", err)
}
// A filter that matches nothing is a no-op.
if err := e.WithTransaction(ctx, func(tx *Transaction) error {
ok, err := tx.RemoveFilteredPolicy(0, "carol")
if err != nil {
return err
}
if ok || tx.HasOperations() {
t.Fatal("A filter matching no rule should buffer nothing")
}
return nil
}); err != nil {
t.Fatalf("Failed to commit transaction: %v", err)
}
if err := e.WithTransaction(ctx, func(tx *Transaction) error {
ok, err := tx.RemoveFilteredPolicy(0, "alice")
if !ok || err != nil {
t.Fatalf("Failed to remove filtered policy in transaction: %v", err)
}
// The removal is visible inside the transaction before committing.
bufferedModel, err := tx.GetBufferedModel()
if err != nil {
return err
}
if has, _ := bufferedModel.HasPolicy("p", "p", []string{"alice", "data1", "read"}); has {
t.Fatal("The buffered model should no longer contain alice's policy")
}
// But not outside of it.
if !hasPolicy(t, e, "alice", "data1", "read") {
t.Fatal("The enforcer model should still contain alice's policy before commit")
}
ok, err = tx.RemoveFilteredGroupingPolicy(1, "admin")
if !ok || err != nil {
t.Fatalf("Failed to remove filtered grouping policy in transaction: %v", err)
}
return nil
}); err != nil {
t.Fatalf("Failed to commit transaction: %v", err)
}
if hasPolicy(t, e, "alice", "data1", "read") || hasPolicy(t, e, "alice", "data2", "write") {
t.Fatal("All of alice's policies should have been removed")
}
if !hasPolicy(t, e, "bob", "data2", "write") {
t.Fatal("bob's policy should have been kept")
}
if hasGroupingPolicy(t, e, "alice", "admin") || hasGroupingPolicy(t, e, "bob", "admin") {
t.Fatal("All grouping policies for admin should have been removed")
}
}
// Test that a rolled back filtered removal leaves the model untouched.
func TestTransactionRemoveFilteredPolicyRollback(t *testing.T) {
e := newTestTransactionalEnforcer(t)
ctx := context.Background()
if err := e.WithTransaction(ctx, func(tx *Transaction) error {
_, err := tx.AddPolicy("alice", "data1", "read")
return err
}); err != nil {
t.Fatalf("Failed to commit transaction: %v", err)
}
wantErr := errors.New("business operation failed")
err := e.WithTransaction(ctx, func(tx *Transaction) error {
if _, err := tx.RemoveFilteredPolicy(0, "alice"); err != nil {
return err
}
return wantErr
})
if !errors.Is(err, wantErr) {
t.Fatalf("Expected the business error to be returned, got %v", err)
}
if !hasPolicy(t, e, "alice", "data1", "read") {
t.Fatal("The policy should still exist after a rollback")
}
}