Visitar URL original
PIP 176: Refactor Doc Bot · Issue #15797 · apache/pulsar · GitHub
Skip to content

PIP 176: Refactor Doc Bot #15797

Closed
Closed

Description

@Anonymitaet

PIP

PIP 176: Refactor Doc Bot to Improve Efficiency of Managing Doc

Issues (new)

  • P0: doc bot check is pending or waiting and documentation label check is changed to label check after it is set to required.

This blocks many PRs, eg. #16298, #16023

This might be caused by GitHub Action limitations https://stackoverflow.com/questions/52200096/github-pull-request-waiting-for-status-to-be-reported

Can you please take a look at it at your earliest convenience? Thank you!

  • P1: when the PR description is empty and the PR author selects labels from Labels, the doc bot should work normally.

  • P2: configure the doc bot to other branches except for master
    - [x] 2.10. Obsever the results and set for other branches if it works well
    - [ ] 2.9
    - [ ] 2.8
    - [ ] 2.7

Issues can't be resolved

Issues (old)

When fixing #15732, @maxsxu found that the doc Bot was implemented by modifying dist rather than src, which makes it hard to maintain and scale.

Consequently, he suggests refactoring the doc Bot along with resolving the following issues in Bot:

Scenario 1

Issue

This PR was marked with doc-related labels and then removed. No doc-related label is marked for this PR.

Expected behavior

In this case, this PR should be labeled w/ doc-label-missing.

image

Scenario 2

Issue

Doc Bot only works for master change.

Expected behavior

Doc Bot should work for all branches and label all PRs.

image

Scenario 3

Issue

Bot labels this PR with several doc labels.

Expected behavior

Bot should label a PR with only a doc label.

image

Improvements

Set documentation label check as one of the GitHub checks.

References

Pulsar Bot

Activity

  1. maxsxu commented on May 26, 2022

    @maxsxu
    Contributor

    Thanks @Anonymitaet brings this out.

    More context from the previous maintainer:

    Current doc-label-check inspired from https://github.com/harupy/auto-labeling. During the doc bot development, just been modifying the compiled dist/index.js to quickly satisfy requirements.

    So from all perspectives, refactoring is necessary. I'll be working on this to make the doc Bot more maintainable and scalable.

  2. Anonymitaet commented on May 27, 2022

    @Anonymitaet
    MemberAuthor

    @maxsxu I've added more improvements as we discussed just now

  3. added
    docYour PR contains doc changes, no matter whether the changes are in markdown or code files.
    on May 30, 2022
  4. changed the title [-]Refactor doc Bot[/-] [+]PIP 176: Refactor Doc Bot[/+] on Jun 10, 2022
  5. maxsxu commented on Jun 11, 2022

    @maxsxu
    Contributor

    The new documentation bot has been implemented at apache/pulsar-test-infra#43

  6. github-actions commented on Aug 7, 2022

    @github-actions

    The issue had no activity for 30 days, mark with Stale label.

  7. tisonkun commented on Dec 6, 2022

    @tisonkun
    Member

    Closed as done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

StaledocYour PR contains doc changes, no matter whether the changes are in markdown or code files.

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions