Repository navigation
buildImage() stream silently fails when build context is too large #538
Description
Today I stumbled upon a problem where the buildImage() function would silently fail when the passed-in build context is too large.
Here's my call:
const stream = await docker.buildImage({ context }, { dockerfile, t })
return new Promise((resolve, reject) => {
docker.modem.followProgress(stream, (err, res) => {
if (err) {
reject(err)
}
resolve(res)
})
})And the context is a path to a directory which has a bunch of files. In my case the context included a large node_modules directory.
Reacted by Daniel Huly, Jo Hue and arszp10
Activity
[-]buildImage() stream stalls when build context is too large[/-][+]buildImage() stream silently fails when build context is too large[/+]dannyhuly commentedon Oct 24, 2019
Same issue here after updating to v3.
In my case the
package-lock.jsonfile was the large file.suggest you use an older version for now
apocas commentedon Oct 24, 2019
Could you give more details about this?
How so "too large"? Larger than what?
apocas commentedon Oct 24, 2019
Is it only happening on v3.x?
Could be related to this: #490
jmahhh commentedon Jan 1, 2020
+1, had this for a
package-lock.jsonof 308K andnode_modulesof 30K. Version 3.0.2.ilkancelikMA commentedon Jan 10, 2020
I can verify that this issue is happening after upgrading to v3.x (working fine with 2.5.8). Not sure if it's related to big files or not but surely works after I remove the folder with big files in it. Otherwise it silently gets stuck. No output, no promise resolving, nothing.
Debug #538
apocas commentedon Feb 5, 2020
Could someone test the branch https://github.com/apocas/dockerode/tree/debug-build against this?
killerall commentedon Feb 27, 2020
@apocas
Same problem here.
With your branch (debug-build), the build worked correctly.
apocas commentedon Mar 17, 2020
Humm so the issue was in the change of tar.pack.
I will revert it and publish.
apocas commentedon Mar 17, 2020
bd5fd18