Implement Pylint

This is the parent issue for tracking parity with Pylint. Below, we've enumerated all Pylint rules.

Rules that are checked off have been implemented in Ruff already (either as a Pylint rule, e.g., PLE0237, or by way of overlap with another linter like Pyflakes, as with missing-format-string-key).

Rules that are crossed out have been removed some consideration. (In most cases, crossed-out rules represent Pylint specific rules, e.g., rules related to Pylint configuration.)

At time of writing, many of the remaining rules require type inference and/or multi-file analysis, and aren't ready to be implemented in Ruff. (See: #970 (comment) for an enumeration.) If you're looking to start work on a specific rule, I'd suggest commenting in the issue, to get some input on whether Ruff is capable of supporting it at present.

For guidance on getting started, see the Contributing documentation.

Note: Don't implement rules that are part of Pylint extension until #1774 is completed. Don't implement rules that mainly target Python 2.

Error

Warning

Convention

Refactor

Need to figure out what the right "check code" approach is here. We could just start to put these under RUF. Or we could do PYE for "Pylint Error", and so on. Or we could use PYL for all of them. In either case, though, we have to allow four-digit codes, as opposed to our current three-digit codes.

I vote for PYE as it would keep the same categories and the migration would be easier.

I'll work on unneeded-not this weekend.

I would suggest PL as the pylint prefix (PLE -> PyLint Error). I think PYE might be a bit ambiguous with PYflakes, PYdocstyle, etc.

Would absolutely love to see this happen. I know flake8 intentionally decided not to implement e.g. unexpected-keyword-arg because it required looking outside of the current file for imported functions.

I expect you've already considered this, and really hope this won't stop ruff from implementing it, but just wanted to raise it.

@relsunkaev

@relsunkaev 👍 Went with PLE! The first code is checked in as PLE1142 (matching E1142 from Pylint).

@MartinBernstorff

@MartinBernstorff - Definitely. The multi-file stuff will come, just not as quickly.

Not sure if it should be separate issue, but looking at missing-function-docstring rule (C0116), pylint's version of it is different. It only requires that a function has docstring some in class hierarchy and does not require over-ridden methods to have a docstring. As an example,

class Foo:
  def validate(self):
    """Doc."""
    ...

class Bar(Foo):
  def validate(self):
    ...

gives no errors in pylint even though second validate is missing docstring being pylint allows inheriting one. This is very useful when implementing interface and the docstring would really be same for all things that subclass.

I'd like to get pointless-statement, unnecessary-ellipsis, and unnecessary-pass in.

Relevant source for defining a pointless-statement: https://github.com/PyCQA/pylint/blob/56121344f6c9c223d8e4477c0cdb58c46c840b4b/pylint/checkers/base/basic_checker.py#L447

A while ago I set out to find all the pylint codes make redundant by type checking.

Unfortunately that code got lost to the sands of time.

You might consider skipping those as type checking tools are very sophisticated, if you can do the effort of compiling that list

I've also thought very long and hard about the fact that pylint appears very sophisticated when it comes to types because it builds on astroid which works very hard to infer types based on code (pre-type-annotations)

Ideally ruff (or any modern linter) is type-aware to be as helpful as possible, but that requires either:

A Rust-implemented type checkers for Python. Short of a large company writing and maintaining this I doubt it'll keep up with the other big dogs
Having the type information be seeded to ruff. Aside from the overhead and protocol, this actually seems feasible.

Implement pylint import-outside-toplevel rule (C0415) (#5180)

[pylint] Implement redefined-argument-from-local (R1704) (#8159)

[`pylint`] Add PLE1141 `DictIterMissingItems` (#9845)

[`pylint`] Implement `if-stmt-min-max` (`PLR1730`, `PLR1731`) (#10002)

[`pylint`] Implement `invalid-bytes-returned` (`E0308`) (#10959)

[`pylint`] Implement `invalid-length-returned` (`E0303`) (#10963)

[`pylint`] Implement `invalid-hash-returned` (`PLE0309`) (#10961)

[`pylint`] Implement `invalid-index-returned` (`PLE0305`) (#10962)

[`pylint`] Implement `missing-maxsplit-arg` (`PLC0207`) (#17454)

Now that Ty is very usable, it might be worth it to check off everything that Ty does. Also, this issue is so long that it might be worth starting a new one with an updated list of Pylint codes.

PR for W0105 (pointless-string-statement): #27253

[`pylint`] Implement `missing-maxsplit-arg` (`PLC0207`) (#17454)

feat(#4): configure pylint to defer to ruff's enabled rules and mirro…

[`pylint`] Implement `no-method-argument` (`PLE0211`) (#29748)

no-method-argument / E0211 (PLE0211) could be checked off now, as it was implemented in #29748 and released in Ruff 0.17.5.

possibly-used-before-assignment / E0606 is missing from the list (mentioned in several comments above).

The following rules are missing the corresponding Ruff rule (mentioned somewhere above):

dict-iter-missing-items / E1141 (PLE1141)
invalid-envvar-value / E1507 (PLE1507)
invalid-str-returned / E0307 (PLE0307)
redefined-slots-in-subclass / W0244 (PLW0244)
self-cls-assignment / W0642 (PLW0642)
shallow-copy-environ / W1507 (PLW1507)
stop-iteration-return / R1708 (PLR1708)

And a bit of nitpicking:

unnecessary-ellipsis / W2301 (`PIE790) is missing one backtick (after PIE790).
wrong-import-position / C0413 (E402 ) is not formatted properly (extra space after E402).
singleton-comparison / C0121 (E711 , E712) is not formatted properly (extra space after E711).

Navigation Menu

Repository navigation

Implement Pylint #970

Error

Warning

Convention

Refactor

444 remaining items

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Implement Pylint #970

Description

Error

Warning

Convention

Refactor

Activity

charliermarsh commented on Nov 30, 2022

JonathanPlasse commented on Nov 30, 2022

harupy commented on Dec 1, 2022

relsunkaev commented on Dec 1, 2022

MartinBernstorff commented on Dec 1, 2022

charliermarsh commented on Dec 1, 2022

charliermarsh commented on Dec 1, 2022

hmc-cs-mdrissi commented on Dec 8, 2022

charliermarsh commented on Jan 5, 2023

charliermarsh commented on Jan 5, 2023

thejcannon commented on Jan 12, 2023

thejcannon commented on Jan 12, 2023

444 remaining items

NeilGirdhar commented on May 23, 2026

oehlschl commented on Jul 28, 2026

BLKSerene commented on Nov 13, 2026

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions