Visitar URL original
chore: fix deny.toml and get it to run in CI by markovejnovic · Pull Request #3808 · atuinsh/atuin · GitHub
Skip to content

chore: fix deny.toml and get it to run in CI - #3808

Merged
markovejnovic merged 8 commits into
mainfrom
chore/modernize-cargo-deny
Jul 30, 2026
Merged

markovejnovic merged 8 commits into
mainfrom
chore/modernize-cargo-deny

Conversation

@markovejnovic

@markovejnovic markovejnovic commented Jul 30, 2026 •

Copy link
Copy Markdown
Member
  • deny.toml was malformed. 0.16 changed the schema, so we needed to fix that.
  • added some licenses that we were lacking
  • added ci for cargo-deny

…dvisory debt

The repo's deny.toml predated cargo-deny 0.16's schema rewrite and no longer
ran against a current cargo-deny; `cargo deny check` now passes on main.

- Migrate to the 0.16 schema: root options into [graph]; drop removed
  lint-level fields (vulnerability/notice/unlicensed/copyleft/default); map
  `unmaintained` to a Scope.
- Allow permissive licenses that were rejected: BSL-1.0 (Boost, not the
  Business Source License), CC0-1.0, CDLA-Permissive-2.0, Unicode-3.0, Zlib.
- Ignore RUSTSEC-2026-0194/0195 (quick-xml via wayland-scanner): a build-time
  proc-macro that parses trusted, bundled protocol XML and is never linked
  into the shipped binary; the patched quick-xml is semver-incompatible via
  arboard's transitive pin.
- Add the missing `license` field to atuin-search-bench.
- Keep `unmaintained = "none"` (documented): daemonize v0.5.0
  (RUSTSEC-2025-0069) is a direct dependency, unmaintained with no safe upgrade.

No CI job runs cargo-deny yet; this makes the config runnable and green so one
can be added.
@greptile-apps

greptile-apps Bot commented Jul 30, 2026 •

Copy link
Copy Markdown
Contributor

Greptile Summary

Modernizes cargo-deny configuration and adds automated dependency-policy checks.

  • Adds a cargo-deny CI job.
  • Updates advisory, license, ban, and source policies.
  • Inherits the workspace license for atuin-search-bench.

Confidence Score: 5/5

The PR appears safe to merge.

No blocking failure remains.

Important Files Changed

Filename Overview
.github/workflows/rust.yml Adds a dedicated cargo-deny check job.
deny.toml Migrates the configuration to the current schema and updates advisory and license policy.
crates/atuin-search-bench/Cargo.toml Adds the workspace license declaration.

Reviews (2): Last reviewed commit: "chore(deny): scope CC0-1.0 to the notify..." | Re-trigger Greptile

@codspeed

codspeed Bot commented Jul 30, 2026 •

Copy link
Copy Markdown
Contributor

Merging this PR will improve performance by 20.29%

⚠️ Unknown Walltime execution environment detected

Using the Walltime instrument on standard Hosted Runners will lead to inconsistent data.

For the most accurate results, we recommend using CodSpeed Macro Runners: bare-metal machines fine-tuned for performance measurement consistency.

⚡ 1 improved benchmark
✅ 50 untouched benchmarks
⏩ 43 skipped benchmarks1

Performance Changes

Mode Benchmark BASE HEAD Efficiency
⚡ WallTime deserialize[1] 249 ns 207 ns +20.29%

Tip

Curious why this is faster? Comment @codspeedbot explain why this is faster on this PR, or directly use the CodSpeed MCP with your agent.


Comparing chore/modernize-cargo-deny (3c69e40) with main (7330522)

Open in CodSpeed

Footnotes

  1. 43 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩

Adds a deny job to the Rust workflow that runs `cargo deny check`
(advisories, bans, licenses, sources) so dependency policy is enforced
in CI, now that deny.toml runs against a current cargo-deny.
Comment thread deny.toml Resolved
Comment thread deny.toml Resolved
Replaces the hand-rolled taiki-e/install-action + `cargo deny check`
job with the official cargo-deny GitHub Action.
Comment thread deny.toml Resolved
Comment thread deny.toml Resolved
Comment thread deny.toml Resolved
CC0-1.0 waives copyright but not patents, so a blanket allow is risky.
Remove it from the global allow-list and permit it only for notify (the
sole crate that requires it); any other CC0 crate is now flagged.
- advisories: unmaintained none -> workspace (ignore daemonize,
  RUSTSEC-2025-0069); yanked warn -> deny
- bans: wildcards warn -> deny; multiple-versions allow -> warn
- sources: unknown-registry warn -> deny; add unknown-git = deny and an
  explicit crates.io allow-registry

Verified: cargo deny check stays green (advisories/bans/licenses/sources ok).
config 0.15.25 drops its direct winnow 0.7 dependency, so the tree no
longer carries both winnow 0.7 and 1.0.
@socket-security

Copy link
Copy Markdown

Review the following changes in direct dependencies. Learn more about Socket for GitHub.

Diff Package Supply Chain
Security
Vulnerability Quality Maintenance License
Updatedcargo/​config@​0.15.21 ⏵ 0.15.259910095100100

View full report

@markovejnovic markovejnovic changed the title Modernize deny.toml for cargo-deny 0.16 and fix license/advisory debt chore: fix deny.toml and get it to run in CI Jul 30, 2026
@markovejnovic
markovejnovic merged commit 6c9f57a into main Jul 30, 2026
30 checks passed
@markovejnovic
markovejnovic deleted the chore/modernize-cargo-deny branch July 30, 2026 22:32
ellie added a commit that referenced this pull request Aug 3, 2026
### Bug Fixes

- *(client)* Avoid panic decoding an empty encryption key
([#3803](#3803))
- *(client)* Keep sqlx-postgres out of the client crate
([#2884](#2884))
([#3823](#3823))
- *(config)* Preserve comments in `atuin config set`
([#3766](#3766))
- *(search)* Correct fuzzy result ranking
([#3603](#3603))
([#3624](#3624))
- Fix atuin-search-bench/benches/search.rs
([#3788](#3788))
- Close OSC133 C when launching Atuin AI to prevent content erasure
([#3794](#3794))
- Authenticate beta release push as atuin-bot
([#3809](#3809))
- Copy vendored axoasset into docker builder stage
([#3816](#3816))


### Documentation

- Clarify update check network, provide build command
([#3767](#3767))
- Remove old i18n docs
([#3787](#3787))
- Use shell-agnostic install command in quickstart pages
([#3820](#3820))
- Document named stats periods (today/week/month/year)
([#3821](#3821))
- State minimum supported Rust version in install guide
([#3822](#3822))
- Document iTerm2 tmux popup incompatibility
([#3826](#3826))
- Clarify key binding snippets belong in shell startup file
([#3837](#3837))
- Mention RustRover in IDE integration guidance
([#3834](#3834))


### Features

- *(client)* Show intent in inspector
([#3804](#3804))
- *(client)* Enable pty-proxy via config
([#3828](#3828))
- *(config)* Validate new settings in `atuin config set` before writing
them to disk ([#3769](#3769))
- *(lab)* Experimental `atuin lab share`
- *(search)* Remove the "skim" engine
([#3825](#3825))
- Remove word with ALT-Backspace ALT-D
([#2457](#2457))
- Add scheduled beta release workflow
([#3805](#3805))
- Migrate TLS backend from rustls to native-tls
([#3807](#3807))
- Make `update` a real subcommand
([#3813](#3813))
- Capability negotiation protocol (client + server)
([#3797](#3797))


### Miscellaneous Tasks

- *(ci)* Fix `package` step
([#3770](#3770))
- Remove Store trait
([#3779](#3779))
- Daemon search benchmark (divan + CodSpeed)
([#3763](#3763))
- Run CodSpeed benchmarks on macro runners in walltime mode
([#3786](#3786))
- Add `OrFilter` as a replacement for `Vec`s as filter lists
([#3768](#3768))
- Add `atuin-domain` crate for shared domain types
([#3790](#3790))
- Run CodSpeed walltime benchmarks on depot-macos-26
([#3791](#3791))
- Fix deny.toml and get it to run in CI
([#3808](#3808))
- Remove codspeed workflow
([#3812](#3812))
- Richer logging for atuin-server
([#2564](#2564))
- Hide --active sharing
([#3846](#3846))


### Refactor

- *(deps)* Bump thiserror from 2.0.18 to 2.0.19
([#3839](#3839))
- *(deps)* Bump strum_macros from 0.27.2 to 0.28.0
([#3841](#3841))
- *(deps)* Bump tonic-types from 0.14.5 to 0.14.6
([#3842](#3842))
- *(deps)* Bump pulldown-cmark from 0.13.3 to 0.13.4
([#3840](#3840))
- *(deps)* Bump itertools from 0.14.0 to 0.15.0
([#3838](#3838))
- Adopt enum_dispatch for enum trait delegation
([#3806](#3806))


### Testing

- Adopt rstest across the workspace test suite
([#3785](#3785))


### Daemon

- Replace nucleo with frizbee, rank by match quality with frecency
tiebreak ([#3782](#3782))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants