Repository navigation
Generic _ fieds handling #53
Description
Example:
data Solid = Solid {
_id :: String,
solidStr :: String
} deriving (Show, Eq, Data, Typeable)
solidJson = "{\"_id\":\"a\",\"solidStr\":\"s\"}"
And now big headahe:
decode solidJson :: Maybe Solid
Expect:
Just (Solid {_id = "a", solidStr="s"})
But got:
Nothing
This happens only if _-fields in JSON. But I use aeson for CouchDB. And CouchDB sends "system" fields _id and _rev.
Activity
bos commentedon Dec 21, 2011
This looks nasty. I think @basvandijk introduced the
_mangling - I'd like him to weigh in before I take the pull request.basvandijk commentedon Dec 21, 2011
No, I think the _ mangling originally came from the
jsonpackage. The patch: a1ee5a5 first introduced it.I never liked the mangling so I'm OK with removing it.
And if someone really wants to have automatic
FromJSONandToJSONinstances with _ mangling she can usederiveJSON and do the mangling herself.
EduardSergeev commentedon Jan 3, 2012
Btw, the above example will work as expected if
__idfield is used.The current mangling does look like a hack and should probably be removed but nevertheless it is breaking change. Shouldn't it first go through
DEPRECATEDpragma stage?Anyway, I just fixed the broken hack but I have no objections to removing entire hack altogether.
Bump version to 0.6.0.0
Describe the gh-53 fix in the release notes.
bos commentedon Jan 6, 2012
I'm going to wait a little before releasing 0.6, in case any more bits need fixing.
Get rid of "_"-prefixed field name mangling.
Bump version to 0.6.0.0
Describe the haskellgh-53 fix in the release notes.