Visitar URL original
development workflow is slow - for eg. no test cases · Issue #36 · browserstack/browserstack-runner · GitHub
Skip to content
This repository was archived by the owner on May 27, 2026. It is now read-only.
This repository was archived by the owner on May 27, 2026. It is now read-only.

development workflow is slow - for eg. no test cases #36

Description

@nakula

If you've followed the changes and my comments above, continue here: My changes here break the runner of anything that isn't QUnit. Addressing that requires a lot more work and testing with each supported framework. Since there are no unit tests, testing each changes requires a rather slow run of browserstack-runner. Improving the development workflow should therefore have the highest priority, before anything else is addressed, since that will speed everything else up a lot. I have no idea how to do that, though.

Reference: #35

Activity

  1. jzaefferer commented on Mar 13, 2014

    @jzaefferer
    Contributor

    One thing to do is add some infrastructure for running regular unit tests, e.g. with nodeunit. Something like formatting "tracebacks" is a good candidate for unit tests.

  2. jzaefferer commented on Mar 13, 2014

    @jzaefferer
    Contributor

    Otherwise having simple testsuite for each supported unit test library, so that I can run them directly within the project, would help. Along with sample log outputs to create better output formatting.

  3. nakula commented on Apr 12, 2014

    @nakula
    ContributorAuthor

    @rahulnwn @dhimil added some repos and workflow for testing all supported frameworks using ruby script for now https://github.com/browserstack/browserstack-runner/compare/testing

  4. dhimil commented on Apr 16, 2014

    @dhimil
    Contributor

    we can run @nakula's branch with travis to do end to end testing with BrowserStack.

  5. jzaefferer commented on Oct 17, 2014

    @jzaefferer
    Contributor

    Between npm test (added in #97) and ruby tests/test.rb I think this can be closed.

  6. nakula commented on Oct 17, 2014

    @nakula
    ContributorAuthor

    does ruby test cases help?

    On Fri, Oct 17, 2014 at 4:41 PM, Jörn Zaefferer notifications@github.com
    wrote:

    Between npm test (added in #97
    #97) and ruby
    tests/test.rb I think this can be closed.

    —
    Reply to this email directly or view it on GitHub
    #36 (comment)
    .

    regards
    Nakul Aggarwal
    www.browserstack.com

  7. jzaefferer commented on Oct 17, 2014

    @jzaefferer
    Contributor

    Yes, it does.

  8. nakula commented on Oct 18, 2014

    @nakula
    ContributorAuthor

    but we need more unit test cases, keeping this open will keep reminding us that unit tests are pending, thoughts?

  9. jzaefferer commented on Oct 20, 2014

    @jzaefferer
    Contributor

    That is a good point, test coverage is still pretty low. Though I don't think keeping this ticket open will help. Instead, when reviewing pull requests, make sure that test coverage is increasing with each change.

  10. nakula commented on Oct 20, 2014

    @nakula
    ContributorAuthor

    :D

    On Mon, Oct 20, 2014 at 3:26 PM, Jörn Zaefferer notifications@github.com
    wrote:

    That is a good point, test coverage is still pretty low. Though I don't
    think keeping this ticket open will help. Instead, when reviewing pull
    requests, make sure that test coverage is increasing with each change.

    —
    Reply to this email directly or view it on GitHub
    #36 (comment)
    .

    regards
    Nakul Aggarwal
    www.browserstack.com

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions