Visitar URL original
fix zizmor checks · Issue #963 · canonical/testflinger · GitHub
Skip to content

fix zizmor checks #963

Open
Open

Description

@rene-oromtz

zizmor 1.23.0 added a check for secrets outside envs: https://docs.zizmor.sh/audits/#secrets-outside-env

We need to determine if possible to set environment secrets or add an ignore if this is not possible.
Reference run: https://github.com/canonical/testflinger/actions/runs/22961442709/job/66652916870?pr=962

Activity

  1. syncronize-issues-to-jira commented on Mar 11, 2026

    @syncronize-issues-to-jira

    Thank you for reporting your feedback to us!

    The internal ticket has been created: https://warthogs.atlassian.net/browse/CERTTF-857.

    This message was autogenerated

  2. rene-oromtz commented on Apr 8, 2026

    @rene-oromtz
    CollaboratorAuthor

    As per https://docs.zizmor.sh/audits/#secrets-outside-env seems that once zizmor 1.24 is released, only auditor persona will get this type of warnings.
    Since we are using pedantic persona, the workflow failure will fix by itself. We may still need to evaluate if we should implement this as best practice.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions