Repository navigation
HTML Depends on TypeScript #253
Description
Latest versions.
For which package is this issue?
HTML
Describe the issue in a sentence or two.
The HTML package depends on TypeScript, despite only using as a Dev Dep
Issue Type (Can be multiple)
- Build - Can’t install or import the SDK
- Performance - Performance issues
- Behaviour - Functions aren’t working as expected
- Documentation - Inconsistency between the docs and behaviour
- Incorrect Types
- Other (Install)
Steps to reproduce
https://www.npmjs.com/package/@cloudinary/html?activeTab=dependencies
Error screenshots
n/a
Browsers (if issue relates to UI, else ignore)
n/a
Versions and Libraries (fill in the version numbers)
package SDK version
Node - n/a (Deno)
NPM - n/a (Deno)
Config Files (Please paste the following files if possible)
package.json (n/a)
deno.json (trimmed for brevity):
{
"nodeModulesDir": "auto",
"imports": {
"@biomejs/biome": "npm:@biomejs/biome@^1.9.4",
"@cloudinary/react": "https://esm.sh/@cloudinary/react@1.14.0?external=*",
"@cloudinary/url-gen": "npm:@cloudinary/url-gen@^1.21.0",
"@fresh/plugin-tailwind": "jsr:@fresh/plugin-tailwind@^0.0.1-alpha.7",
"@preact/signals": "npm:@preact/signals@^1.3.2",
"fresh": "jsr:@fresh/core@^2.0.0-alpha.29",
"preact": "npm:preact@^10.26.2",
"tailwindcss": "npm:tailwindcss@^3.4.17"
},
"scopes": {
"https://esm.sh/": {
"@cloudinary/hrml": "npm:@cloudinary/html@",
"@types/react": "npm:preact@10.26.2/compat",
"client-only": "npm:client-only@0.0.1",
"react": "npm:preact@10.26.2/compat",
"react/jsx-runtime": "npm:preact@10.26.2/jsx-runtime",
"react-dom": "npm:preact@10.26.2/compat",
"react-dom/test-utils": "npm:preact@10.26.2/test-utils"
}
}
}Repository
n/a
Activity
lishaduck commentedon Feb 27, 2025
Also,
isBrowseris based onwindowinstead ofdocument, which means it's incorrect while running on Deno (and other modern runtimes).frontend-frameworks/packages/html/src/utils/isBrowser.ts
Lines 4 to 6 in fbb7d15
lishaduck commentedon Feb 27, 2025
And there's no
exportsfield, so it can't get consumed as ESM and it doesn't use .mjs extension for ESM so it probably can't be imported even with an exports field.I'd be happy to help clean it up in a month (project I'm using cloudinary for is very far behind).
dannyv-cloudinary commentedon Feb 28, 2025
Hi @lishaduck.
Thanks for your comments. We will review this internally and get back to you.
lishaduck commentedon Apr 3, 2025
It's been a month! Would y'all be open to a PR(s) to clean up the repo?
(Also, to double check, y'all don't have a CLA, do you?)
tommyg-cld commentedon Apr 8, 2025
@lishaduck sorry for the delay, we have opened an internal ticket to work on this further, however there is no ETA currently but we will post again when we complete it.