Visitar URL original
fix: Key refresh should set no-cache to get most up to date keys · coreos/go-oidc@f77e01c · GitHub
Skip to content

Commit f77e01c

Browse files
Yanni8ericchiang
authored andcommitted
fix: Key refresh should set no-cache to get most up to date keys
1 parent da6b3bf commit f77e01c

2 files changed

Lines changed: 41 additions & 0 deletions

File tree

‎oidc/jwks.go‎

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -238,6 +238,7 @@ func (r *RemoteKeySet) updateKeys() ([]jose.JSONWebKey, error) {
238238
if err != nil {
239239
return nil, fmt.Errorf("oidc: can't create request: %v", err)
240240
}
241+
req.Header.Set("Cache-Control", "no-cache")
241242

242243
resp, err := doRequest(r.ctx, req)
243244
if err != nil {

‎oidc/jwks_test.go‎

Lines changed: 40 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -286,6 +286,46 @@ func TestRotation(t *testing.T) {
286286
}
287287
}
288288

289+
func TestUpdateKeysSendsCacheControlNoCache(t *testing.T) {
290+
ctx, cancel := context.WithCancel(context.Background())
291+
defer cancel()
292+
293+
key := newRSAKey(t)
294+
var requestHeaders []http.Header
295+
296+
s := httptest.NewServer(http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
297+
requestHeaders = append(requestHeaders, r.Header.Clone())
298+
if err := json.NewEncoder(w).Encode(jose.JSONWebKeySet{
299+
Keys: []jose.JSONWebKey{key.jwk()},
300+
}); err != nil {
301+
panic(err)
302+
}
303+
}))
304+
defer s.Close()
305+
306+
rks := newRemoteKeySet(ctx, s.URL)
307+
308+
payload := []byte("a secret")
309+
jws, err := jose.ParseSigned(key.sign(t, payload), allAlgs)
310+
if err != nil {
311+
t.Fatal(err)
312+
}
313+
314+
if _, err := rks.verify(ctx, jws); err != nil {
315+
t.Fatalf("failed to verify: %v", err)
316+
}
317+
318+
if len(requestHeaders) == 0 {
319+
t.Fatal("expected at least one request to the JWKS endpoint")
320+
}
321+
for i, h := range requestHeaders {
322+
if got := h.Get("Cache-Control"); got != "no-cache" {
323+
t.Errorf("request %d: expected Cache-Control: no-cache, got %q", i, got)
324+
}
325+
}
326+
}
327+
328+
289329
func BenchmarkVerify(b *testing.B) {
290330
ctx, cancel := context.WithCancel(context.Background())
291331
defer cancel()

0 commit comments

Comments
 (0)