Repository navigation
Expand file tree
/
Copy pathetcddefrag_controller_test.go
More file actions
762 lines (699 loc) · 33.5 KB
/
Copy pathetcddefrag_controller_test.go
File metadata and controls
762 lines (699 loc) · 33.5 KB
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
536
537
538
539
540
541
542
543
544
545
546
547
548
549
550
551
552
553
554
555
556
557
558
559
560
561
562
563
564
565
566
567
568
569
570
571
572
573
574
575
576
577
578
579
580
581
582
583
584
585
586
587
588
589
590
591
592
593
594
595
596
597
598
599
600
601
602
603
604
605
606
607
608
609
610
611
612
613
614
615
616
617
618
619
620
621
622
623
624
625
626
627
628
629
630
631
632
633
634
635
636
637
638
639
640
641
642
643
644
645
646
647
648
649
650
651
652
653
654
655
656
657
658
659
660
661
662
663
664
665
666
667
668
669
670
671
672
673
674
675
676
677
678
679
680
681
682
683
684
685
686
687
688
689
690
691
692
693
694
695
696
697
698
699
700
701
702
703
704
705
706
707
708
709
710
711
712
713
714
715
716
717
718
719
720
721
722
723
724
725
726
727
728
729
730
731
732
733
734
735
736
737
738
739
740
741
742
743
744
745
746
747
748
749
750
751
752
753
754
755
756
757
758
759
760
761
762
/*
Copyright 2023 Timofey Larkin.
Licensed under the Apache License, Version 2.0 (the "License");
you may not use this file except in compliance with the License.
You may obtain a copy of the License at
http://www.apache.org/licenses/LICENSE-2.0
*/
package controllers
import (
"context"
"errors"
"fmt"
"strings"
"testing"
"time"
etcdserverpb "go.etcd.io/etcd/api/v3/etcdserverpb"
clientv3 "go.etcd.io/etcd/client/v3"
corev1 "k8s.io/api/core/v1"
"k8s.io/apimachinery/pkg/api/resource"
metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
"k8s.io/client-go/tools/record"
ctrl "sigs.k8s.io/controller-runtime"
"sigs.k8s.io/controller-runtime/pkg/client"
lll "github.com/cozystack/etcd-operator/api/v1alpha2"
)
var gib = int64(1 << 30)
func TestDefragRuleTriggered(t *testing.T) {
q := func(s string) *resource.Quantity { v := resource.MustParse(s); return &v }
quota := 2 * gib
cases := []struct {
name string
rule *lll.DefragRule
dbSize, dbSizeInUse int64
want bool
}{
{"nil rule, no fragmentation", nil, 100 << 20, 100 << 20, false},
{"nil rule, fragmentation over 200Mi default", nil, 500 << 20, 100 << 20, true},
{"all: unconditional even with nothing to reclaim", &lll.DefragRule{All: true}, 10 << 20, 10 << 20, true},
{"freeSpaceAbove not met", &lll.DefragRule{FreeSpaceAbove: q("1Gi")}, 500 << 20, 100 << 20, false},
{"freeSpaceAbove met", &lll.DefragRule{FreeSpaceAbove: q("200Mi")}, 500 << 20, 100 << 20, true},
{"quota arm: full but unfragmented never fires", &lll.DefragRule{QuotaUsageAbove: "80%"}, int64(1.9 * float64(gib)), int64(1.9 * float64(gib)), false},
{"quota arm: under pressure with reclaimable fires", &lll.DefragRule{QuotaUsageAbove: "80%", MinReclaim: q("32Mi")}, int64(1.9 * float64(gib)), int64(1.9*float64(gib)) - (64 << 20), true},
{"quota arm: 100% is inert, only the free-space floor applies", &lll.DefragRule{QuotaUsageAbove: "100%", MinReclaim: q("32Mi")}, int64(1.9 * float64(gib)), int64(1.9*float64(gib)) - (64 << 20), false},
}
for _, tc := range cases {
t.Run(tc.name, func(t *testing.T) {
got, _ := defragRuleTriggered(tc.rule, tc.dbSize, tc.dbSizeInUse, quota)
if got != tc.want {
t.Errorf("defragRuleTriggered = %v, want %v", got, tc.want)
}
})
}
}
// ── controller integration (fake etcd + fake kube client) ───────────────────
func defragEndpoint(name string) string { return fmt.Sprintf("http://%s.c1.ns.svc:2379", name) }
func defragCluster3() (*lll.EtcdCluster, []lll.EtcdMember) {
cluster := &lll.EtcdCluster{
ObjectMeta: metav1.ObjectMeta{Name: "c1", Namespace: "ns"},
Spec: lll.EtcdClusterSpec{Replicas: ptrInt32(3), Version: "3.6.11", Storage: lll.StorageSpec{Size: resource.MustParse("1Gi")}},
Status: lll.EtcdClusterStatus{ClusterID: "abc", Observed: &lll.ObservedClusterSpec{Replicas: 3, Version: "3.6.11", Storage: lll.StorageSpec{Size: resource.MustParse("1Gi")}}},
}
var members []lll.EtcdMember
for i := 0; i < 3; i++ {
name := fmt.Sprintf("c1-%d", i)
members = append(members, lll.EtcdMember{
ObjectMeta: metav1.ObjectMeta{Name: name, Namespace: "ns", Labels: memberLabels("c1", name)},
Spec: lll.EtcdMemberSpec{ClusterName: "c1", Version: "3.6.11", Storage: lll.StorageSpec{Size: resource.MustParse("1Gi")}, InitialCluster: "x", ClusterToken: "t"},
Status: lll.EtcdMemberStatus{PodName: name},
})
}
return cluster, members
}
func status(memberID, leader uint64, dbSize, inUse int64) *clientv3.StatusResponse {
return &clientv3.StatusResponse{Header: &etcdserverpb.ResponseHeader{MemberId: memberID}, Leader: leader, DbSize: dbSize, DbSizeInUse: inUse}
}
// statusAlarm is status() with the given active-alarm lines, formatted the way
// etcd's Status RPC reports them in StatusResponse.Errors.
func statusAlarm(memberID, leader uint64, dbSize, inUse int64, alarms ...etcdserverpb.AlarmType) *clientv3.StatusResponse {
s := status(memberID, leader, dbSize, inUse)
for _, a := range alarms {
s.Errors = append(s.Errors, fmt.Sprintf("memberID:%d alarm:%s", memberID, a.String()))
}
return s
}
func objs(cluster *lll.EtcdCluster, members []lll.EtcdMember, dfs ...*lll.EtcdDefrag) []client.Object {
out := []client.Object{cluster}
for i := range members {
out = append(out, &members[i])
}
for _, d := range dfs {
out = append(out, d)
}
return out
}
// driveDefrag reconciles d1 until it reaches a terminal phase or the cap.
func driveDefrag(t *testing.T, r *EtcdDefragReconciler, c client.Client, name string) *lll.EtcdDefrag {
t.Helper()
ctx := context.Background()
req := ctrl.Request{NamespacedName: nn(name, "ns")}
for i := 0; i < 20; i++ {
if _, err := r.Reconcile(ctx, req); err != nil {
t.Fatalf("reconcile: %v", err)
}
df := &lll.EtcdDefrag{}
if err := c.Get(ctx, nn(name, "ns"), df); err != nil {
t.Fatalf("get %s: %v", name, err)
}
if df.Status.Phase == lll.EtcdDefragPhaseComplete || df.Status.Phase == lll.EtcdDefragPhaseFailed {
return df
}
}
df := &lll.EtcdDefrag{}
_ = c.Get(ctx, nn(name, "ns"), df)
return df
}
func nn(name, ns string) client.ObjectKey { return client.ObjectKey{Name: name, Namespace: ns} }
// A fragmented follower on a healthy cluster is defragmented; the leader and an
// unfragmented follower are skipped; the follower is done before the leader.
func TestEtcdDefrag_DefragmentsFragmentedMember(t *testing.T) {
cluster, members := defragCluster3()
df := &lll.EtcdDefrag{ObjectMeta: metav1.ObjectMeta{Name: "d1", Namespace: "ns"}, Spec: lll.EtcdDefragSpec{ClusterRef: corev1.LocalObjectReference{Name: "c1"}}}
c, s := newTestClient(t, objs(cluster, members, df)...)
fe := newFakeEtcd(0xabc)
fe.leader = 10
fe.statusByEndpoint = map[string]*clientv3.StatusResponse{
defragEndpoint("c1-0"): status(10, 10, 100<<20, 100<<20), // leader, clean
defragEndpoint("c1-1"): status(11, 10, 500<<20, 100<<20), // follower, fragmented
defragEndpoint("c1-2"): status(12, 10, 100<<20, 100<<20), // follower, clean
}
r := &EtcdDefragReconciler{Client: c, Scheme: s, EtcdClientFactory: factoryReturning(fe), Recorder: record.NewFakeRecorder(20)}
got := driveDefrag(t, r, c, "d1")
if got.Status.Phase != lll.EtcdDefragPhaseComplete {
t.Fatalf("phase = %q, want Complete", got.Status.Phase)
}
if len(fe.defragCalls) != 1 || fe.defragCalls[0] != defragEndpoint("c1-1") {
t.Fatalf("defragCalls = %v, want exactly [c1-1]", fe.defragCalls)
}
if got.Status.Defragmented != 1 {
t.Errorf("Defragmented = %d, want 1", got.Status.Defragmented)
}
// Members recorded; the fragmented follower Defragmented, leader last.
outcome := map[string]lll.DefragOutcome{}
for _, m := range got.Status.Members {
outcome[m.Name] = m.Outcome
}
if outcome["c1-1"] != lll.DefragOutcomeDefragmented {
t.Errorf("c1-1 outcome = %q, want Defragmented", outcome["c1-1"])
}
if got.Status.Members[len(got.Status.Members)-1].Role != lll.MemberRoleLeader {
t.Errorf("leader not last in the plan: %+v", got.Status.Members)
}
}
// rule.all defragments every member unconditionally.
func TestEtcdDefrag_RuleAllDefragmentsEveryone(t *testing.T) {
cluster, members := defragCluster3()
df := &lll.EtcdDefrag{ObjectMeta: metav1.ObjectMeta{Name: "d1", Namespace: "ns"}, Spec: lll.EtcdDefragSpec{ClusterRef: corev1.LocalObjectReference{Name: "c1"}, Rule: &lll.DefragRule{All: true}}}
c, s := newTestClient(t, objs(cluster, members, df)...)
fe := newFakeEtcd(0xabc)
fe.leader = 10
fe.statusByEndpoint = map[string]*clientv3.StatusResponse{
defragEndpoint("c1-0"): status(10, 10, 50<<20, 50<<20),
defragEndpoint("c1-1"): status(11, 10, 50<<20, 50<<20),
defragEndpoint("c1-2"): status(12, 10, 50<<20, 50<<20),
}
r := &EtcdDefragReconciler{Client: c, Scheme: s, EtcdClientFactory: factoryReturning(fe), Recorder: record.NewFakeRecorder(20)}
got := driveDefrag(t, r, c, "d1")
if got.Status.Phase != lll.EtcdDefragPhaseComplete || got.Status.Defragmented != 3 {
t.Fatalf("phase=%q defragmented=%d, want Complete/3", got.Status.Phase, got.Status.Defragmented)
}
if len(fe.defragCalls) != 3 {
t.Fatalf("defragCalls = %v, want all 3", fe.defragCalls)
}
// Leader defragmented last.
if fe.defragCalls[2] != defragEndpoint("c1-0") {
t.Errorf("leader c1-0 not defragmented last: %v", fe.defragCalls)
}
}
// Quorum lost (two members unreachable) → no defrag, phase Pending,
// DefragChecked=False/ClusterNotHealthy, a DefragDeferred event.
func TestEtcdDefrag_DeferredWhenUnhealthy(t *testing.T) {
cluster, members := defragCluster3()
df := &lll.EtcdDefrag{ObjectMeta: metav1.ObjectMeta{Name: "d1", Namespace: "ns"}, Spec: lll.EtcdDefragSpec{ClusterRef: corev1.LocalObjectReference{Name: "c1"}}}
c, s := newTestClient(t, objs(cluster, members, df)...)
fe := newFakeEtcd(0xabc)
fe.leader = 10
fe.statusByEndpoint = map[string]*clientv3.StatusResponse{
defragEndpoint("c1-0"): status(10, 10, 500<<20, 100<<20),
}
fe.statusErrByEndpoint = map[string]error{
defragEndpoint("c1-1"): errors.New("context deadline exceeded"),
defragEndpoint("c1-2"): errors.New("context deadline exceeded"),
}
rec := record.NewFakeRecorder(20)
r := &EtcdDefragReconciler{Client: c, Scheme: s, EtcdClientFactory: factoryReturning(fe), Recorder: rec}
ctx := context.Background()
res, err := r.Reconcile(ctx, ctrl.Request{NamespacedName: nn("d1", "ns")})
if err != nil {
t.Fatalf("reconcile: %v", err)
}
if res.RequeueAfter == 0 {
t.Errorf("expected a requeue while deferred, got %+v", res)
}
if len(fe.defragCalls) != 0 {
t.Fatalf("defrag ran on an unhealthy cluster: %v", fe.defragCalls)
}
got := &lll.EtcdDefrag{}
if err := c.Get(ctx, nn("d1", "ns"), got); err != nil {
t.Fatal(err)
}
if got.Status.Phase != lll.EtcdDefragPhasePending {
t.Errorf("phase = %q, want Pending", got.Status.Phase)
}
cond := findDefragCond(got)
if cond == nil || cond.Status != metav1.ConditionFalse || cond.Reason != "ClusterNotHealthy" {
t.Errorf("DefragChecked = %+v, want False/ClusterNotHealthy", cond)
}
assertDefragEvent(t, rec, "DefragDeferred")
}
// A failed Defragment RPC lands the run in Failed with the member marked Failed.
func TestEtcdDefrag_FailedRPC(t *testing.T) {
cluster, members := defragCluster3()
df := &lll.EtcdDefrag{ObjectMeta: metav1.ObjectMeta{Name: "d1", Namespace: "ns"}, Spec: lll.EtcdDefragSpec{ClusterRef: corev1.LocalObjectReference{Name: "c1"}, Rule: &lll.DefragRule{All: true}}}
c, s := newTestClient(t, objs(cluster, members, df)...)
fe := newFakeEtcd(0xabc)
fe.leader = 10
fe.defragErr = errors.New("boom")
fe.statusByEndpoint = map[string]*clientv3.StatusResponse{
defragEndpoint("c1-0"): status(10, 10, 50<<20, 50<<20),
defragEndpoint("c1-1"): status(11, 10, 50<<20, 50<<20),
defragEndpoint("c1-2"): status(12, 10, 50<<20, 50<<20),
}
r := &EtcdDefragReconciler{Client: c, Scheme: s, EtcdClientFactory: factoryReturning(fe), Recorder: record.NewFakeRecorder(20)}
got := driveDefrag(t, r, c, "d1")
if got.Status.Phase != lll.EtcdDefragPhaseFailed {
t.Fatalf("phase = %q, want Failed", got.Status.Phase)
}
failed := false
for _, m := range got.Status.Members {
if m.Outcome == lll.DefragOutcomeFailed {
failed = true
}
}
if !failed {
t.Errorf("no member marked Failed: %+v", got.Status.Members)
}
}
// Two EtcdDefrags for one cluster are serialized: only the oldest acts; the
// newer stays Pending and performs no defrag until the first finishes.
func TestEtcdDefrag_SerializedPerCluster(t *testing.T) {
cluster, members := defragCluster3()
older := &lll.EtcdDefrag{ObjectMeta: metav1.ObjectMeta{Name: "d-old", Namespace: "ns", CreationTimestamp: metav1.Unix(100, 0)}, Spec: lll.EtcdDefragSpec{ClusterRef: corev1.LocalObjectReference{Name: "c1"}, Rule: &lll.DefragRule{All: true}}}
newer := &lll.EtcdDefrag{ObjectMeta: metav1.ObjectMeta{Name: "d-new", Namespace: "ns", CreationTimestamp: metav1.Unix(200, 0)}, Spec: lll.EtcdDefragSpec{ClusterRef: corev1.LocalObjectReference{Name: "c1"}, Rule: &lll.DefragRule{All: true}}}
c, s := newTestClient(t, objs(cluster, members, older, newer)...)
fe := newFakeEtcd(0xabc)
fe.leader = 10
fe.statusByEndpoint = map[string]*clientv3.StatusResponse{
defragEndpoint("c1-0"): status(10, 10, 50<<20, 50<<20),
defragEndpoint("c1-1"): status(11, 10, 50<<20, 50<<20),
defragEndpoint("c1-2"): status(12, 10, 50<<20, 50<<20),
}
r := &EtcdDefragReconciler{Client: c, Scheme: s, EtcdClientFactory: factoryReturning(fe), Recorder: record.NewFakeRecorder(20)}
// Reconcile the NEWER one: it must stay Pending and not defrag.
ctx := context.Background()
if _, err := r.Reconcile(ctx, ctrl.Request{NamespacedName: nn("d-new", "ns")}); err != nil {
t.Fatalf("reconcile d-new: %v", err)
}
if len(fe.defragCalls) != 0 {
t.Fatalf("newer EtcdDefrag defragged while an older one is active: %v", fe.defragCalls)
}
got := &lll.EtcdDefrag{}
_ = c.Get(ctx, nn("d-new", "ns"), got)
if got.Status.Phase != lll.EtcdDefragPhasePending {
t.Errorf("d-new phase = %q, want Pending (queued)", got.Status.Phase)
}
}
// A NOSPACE alarm is the case defrag exists to relieve: the health gate admits
// the run rather than refusing the one cluster that needs it, and the alarm is
// disarmed once space has been reclaimed.
func TestEtcdDefrag_NoSpaceAlarmPermitsRunAndDisarms(t *testing.T) {
cluster, members := defragCluster3()
df := &lll.EtcdDefrag{ObjectMeta: metav1.ObjectMeta{Name: "d1", Namespace: "ns"}, Spec: lll.EtcdDefragSpec{ClusterRef: corev1.LocalObjectReference{Name: "c1"}, Rule: &lll.DefragRule{All: true}}}
c, s := newTestClient(t, objs(cluster, members, df)...)
fe := newFakeEtcd(0xabc)
fe.leader = 10
fe.statusByEndpoint = map[string]*clientv3.StatusResponse{
defragEndpoint("c1-0"): statusAlarm(10, 10, 500<<20, 100<<20, etcdserverpb.AlarmType_NOSPACE),
defragEndpoint("c1-1"): statusAlarm(11, 10, 500<<20, 100<<20, etcdserverpb.AlarmType_NOSPACE),
defragEndpoint("c1-2"): statusAlarm(12, 10, 500<<20, 100<<20, etcdserverpb.AlarmType_NOSPACE),
}
fe.alarms = []*etcdserverpb.AlarmMember{{MemberID: 10, Alarm: etcdserverpb.AlarmType_NOSPACE}}
r := &EtcdDefragReconciler{Client: c, Scheme: s, EtcdClientFactory: factoryReturning(fe), Recorder: record.NewFakeRecorder(20)}
got := driveDefrag(t, r, c, "d1")
if got.Status.Phase != lll.EtcdDefragPhaseComplete {
t.Fatalf("phase = %q, want Complete (NOSPACE must not block)", got.Status.Phase)
}
if len(fe.defragCalls) != 3 {
t.Fatalf("defragCalls = %v, want all 3 under NOSPACE", fe.defragCalls)
}
if len(fe.disarmCalls) != 1 || fe.disarmCalls[0].Alarm != etcdserverpb.AlarmType_NOSPACE {
t.Fatalf("disarmCalls = %+v, want one NOSPACE disarm after the sweep", fe.disarmCalls)
}
}
// A CORRUPT alarm blocks the run: it is deferred, not forced.
func TestEtcdDefrag_CorruptAlarmBlocksRun(t *testing.T) {
cluster, members := defragCluster3()
df := &lll.EtcdDefrag{ObjectMeta: metav1.ObjectMeta{Name: "d1", Namespace: "ns"}, Spec: lll.EtcdDefragSpec{ClusterRef: corev1.LocalObjectReference{Name: "c1"}, Rule: &lll.DefragRule{All: true}}}
c, s := newTestClient(t, objs(cluster, members, df)...)
fe := newFakeEtcd(0xabc)
fe.leader = 10
fe.statusByEndpoint = map[string]*clientv3.StatusResponse{
defragEndpoint("c1-0"): statusAlarm(10, 10, 500<<20, 100<<20, etcdserverpb.AlarmType_CORRUPT),
defragEndpoint("c1-1"): status(11, 10, 500<<20, 100<<20),
defragEndpoint("c1-2"): status(12, 10, 500<<20, 100<<20),
}
rec := record.NewFakeRecorder(20)
r := &EtcdDefragReconciler{Client: c, Scheme: s, EtcdClientFactory: factoryReturning(fe), Recorder: rec}
res, err := r.Reconcile(context.Background(), ctrl.Request{NamespacedName: nn("d1", "ns")})
if err != nil {
t.Fatalf("reconcile: %v", err)
}
if res.RequeueAfter == 0 {
t.Errorf("expected a requeue while deferred, got %+v", res)
}
if len(fe.defragCalls) != 0 {
t.Fatalf("defrag ran despite a CORRUPT alarm: %v", fe.defragCalls)
}
got := mustGet(t, c, "d1", "ns", &lll.EtcdDefrag{})
if got.Status.Phase != lll.EtcdDefragPhasePending {
t.Errorf("phase = %q, want Pending", got.Status.Phase)
}
if cond := findDefragCond(got); cond == nil || cond.Reason != "ClusterNotHealthy" {
t.Errorf("DefragChecked = %+v, want ClusterNotHealthy", cond)
}
}
// A run that flaps Pending->Running->Pending must not keep re-stamping StartedAt:
// the active-deadline is measured from it, and re-stamping would let a stuck run
// hold the per-cluster slot forever.
func TestEtcdDefrag_StartedAtNotResetAcrossFlap(t *testing.T) {
cluster, members := defragCluster3()
seeded := metav1.NewTime(time.Now().Add(-25 * time.Minute))
df := &lll.EtcdDefrag{
ObjectMeta: metav1.ObjectMeta{Name: "d1", Namespace: "ns"},
Spec: lll.EtcdDefragSpec{ClusterRef: corev1.LocalObjectReference{Name: "c1"}},
Status: lll.EtcdDefragStatus{Phase: lll.EtcdDefragPhasePending, StartedAt: &seeded},
}
c, s := newTestClient(t, objs(cluster, members, df)...)
fe := newFakeEtcd(0xabc)
fe.leader = 10
fe.statusByEndpoint = map[string]*clientv3.StatusResponse{
defragEndpoint("c1-0"): status(10, 10, 50<<20, 50<<20),
defragEndpoint("c1-1"): status(11, 10, 50<<20, 50<<20),
defragEndpoint("c1-2"): status(12, 10, 50<<20, 50<<20),
}
r := &EtcdDefragReconciler{Client: c, Scheme: s, EtcdClientFactory: factoryReturning(fe), Recorder: record.NewFakeRecorder(20)}
if _, err := r.Reconcile(context.Background(), ctrl.Request{NamespacedName: nn("d1", "ns")}); err != nil {
t.Fatalf("reconcile: %v", err)
}
got := mustGet(t, c, "d1", "ns", &lll.EtcdDefrag{})
if got.Status.StartedAt == nil {
t.Fatal("StartedAt was cleared")
}
if age := time.Since(got.Status.StartedAt.Time); age < 20*time.Minute {
t.Fatalf("StartedAt age = %s, want ~25m (it was reset on the Pending->Running transition)", age)
}
}
// A defrag whose post-defrag Status read fails records the after-size and
// reclaimed bytes as unset rather than reporting a real defrag as reclaiming 0.
func TestMarkMember_AfterSizeUnknownLeavesReclaimedUnset(t *testing.T) {
newDF := func() *lll.EtcdDefrag {
return &lll.EtcdDefrag{Status: lll.EtcdDefragStatus{Members: []lll.MemberDefragStatus{{Name: "m", Outcome: lll.DefragOutcomePending}}}}
}
unknown := newDF()
markMember(unknown, "m", lll.DefragOutcomeDefragmented, "AfterSizeUnavailable",
&memberBackend{status: status(1, 1, 500<<20, 100<<20)})
if m := unknown.Status.Members[0]; m.DBSizeBefore != 500<<20 || m.DBSizeAfter != 0 || m.ReclaimedBytes != 0 {
t.Fatalf("after-size unknown: got before=%d after=%d reclaimed=%d, want before=%d after/reclaimed=0",
m.DBSizeBefore, m.DBSizeAfter, m.ReclaimedBytes, 500<<20)
}
known := newDF()
markMember(known, "m", lll.DefragOutcomeDefragmented, "",
&memberBackend{status: status(1, 1, 500<<20, 100<<20), after: 120 << 20, afterKnown: true})
if m := known.Status.Members[0]; m.DBSizeAfter != 120<<20 || m.ReclaimedBytes != 380<<20 {
t.Fatalf("after-size known: got after=%d reclaimed=%d, want after=%d reclaimed=%d",
m.DBSizeAfter, m.ReclaimedBytes, 120<<20, 380<<20)
}
}
// A NOSPACE sweep where one member's Defragment fails still disarms the alarm:
// the space reclaimed on the members that succeeded is what lifts the read-only
// wedge, so gating the disarm on a wholly-clean run would strand the cluster.
func TestEtcdDefrag_PartialFailureStillDisarmsNoSpace(t *testing.T) {
cluster, members := defragCluster3()
df := &lll.EtcdDefrag{ObjectMeta: metav1.ObjectMeta{Name: "d1", Namespace: "ns"}, Spec: lll.EtcdDefragSpec{ClusterRef: corev1.LocalObjectReference{Name: "c1"}, Rule: &lll.DefragRule{All: true}}}
c, s := newTestClient(t, objs(cluster, members, df)...)
fe := newFakeEtcd(0xabc)
fe.leader = 10
fe.statusByEndpoint = map[string]*clientv3.StatusResponse{
defragEndpoint("c1-0"): statusAlarm(10, 10, 500<<20, 100<<20, etcdserverpb.AlarmType_NOSPACE),
defragEndpoint("c1-1"): statusAlarm(11, 10, 500<<20, 100<<20, etcdserverpb.AlarmType_NOSPACE),
defragEndpoint("c1-2"): statusAlarm(12, 10, 500<<20, 100<<20, etcdserverpb.AlarmType_NOSPACE),
}
fe.alarms = []*etcdserverpb.AlarmMember{{MemberID: 10, Alarm: etcdserverpb.AlarmType_NOSPACE}}
// One follower's Defragment fails; the other follower and the leader succeed.
fe.defragErrByEndpoint = map[string]error{defragEndpoint("c1-1"): errors.New("boom")}
r := &EtcdDefragReconciler{Client: c, Scheme: s, EtcdClientFactory: factoryReturning(fe), Recorder: record.NewFakeRecorder(20)}
got := driveDefrag(t, r, c, "d1")
if got.Status.Phase != lll.EtcdDefragPhaseFailed {
t.Fatalf("phase = %q, want Failed (one member's Defragment failed)", got.Status.Phase)
}
if got.Status.Defragmented != 2 {
t.Fatalf("Defragmented = %d, want 2", got.Status.Defragmented)
}
if len(fe.disarmCalls) != 1 {
t.Fatalf("disarmCalls = %+v, want one NOSPACE disarm despite the failed run", fe.disarmCalls)
}
}
// AlarmList returns one entry per member that raised NOSPACE; a transient disarm
// failure on one must not abandon the rest.
func TestEtcdDefrag_DisarmContinuesAfterFailure(t *testing.T) {
cluster, members := defragCluster3()
df := &lll.EtcdDefrag{ObjectMeta: metav1.ObjectMeta{Name: "d1", Namespace: "ns"}, Spec: lll.EtcdDefragSpec{ClusterRef: corev1.LocalObjectReference{Name: "c1"}, Rule: &lll.DefragRule{All: true}}}
c, s := newTestClient(t, objs(cluster, members, df)...)
fe := newFakeEtcd(0xabc)
fe.leader = 10
fe.statusByEndpoint = map[string]*clientv3.StatusResponse{
defragEndpoint("c1-0"): statusAlarm(10, 10, 500<<20, 100<<20, etcdserverpb.AlarmType_NOSPACE),
defragEndpoint("c1-1"): statusAlarm(11, 10, 500<<20, 100<<20, etcdserverpb.AlarmType_NOSPACE),
defragEndpoint("c1-2"): statusAlarm(12, 10, 500<<20, 100<<20, etcdserverpb.AlarmType_NOSPACE),
}
fe.alarms = []*etcdserverpb.AlarmMember{
{MemberID: 10, Alarm: etcdserverpb.AlarmType_NOSPACE},
{MemberID: 11, Alarm: etcdserverpb.AlarmType_NOSPACE},
{MemberID: 12, Alarm: etcdserverpb.AlarmType_NOSPACE},
}
fe.disarmErrByMember = map[uint64]error{10: errors.New("transient")}
rec := record.NewFakeRecorder(20)
r := &EtcdDefragReconciler{Client: c, Scheme: s, EtcdClientFactory: factoryReturning(fe), Recorder: rec}
got := driveDefrag(t, r, c, "d1")
if got.Status.Phase != lll.EtcdDefragPhaseComplete {
t.Fatalf("phase = %q, want Complete", got.Status.Phase)
}
if len(fe.disarmCalls) != 3 {
t.Fatalf("disarmCalls = %d, want 3 (loop must not abort on the first failure)", len(fe.disarmCalls))
}
assertDefragEvent(t, rec, "AlarmDisarmFailed")
}
// ttlSecondsAfterFinished GCs a finished record once it expires, and requeues
// (not deletes) one that has not.
func TestEtcdDefrag_TTLGarbageCollects(t *testing.T) {
ctx := context.Background()
newFinished := func(name string, completedAt metav1.Time) *lll.EtcdDefrag {
return &lll.EtcdDefrag{
ObjectMeta: metav1.ObjectMeta{Name: name, Namespace: "ns"},
Spec: lll.EtcdDefragSpec{ClusterRef: corev1.LocalObjectReference{Name: "c1"}, TTLSecondsAfterFinished: ptrInt32(3600)},
Status: lll.EtcdDefragStatus{Phase: lll.EtcdDefragPhaseComplete, CompletedAt: &completedAt},
}
}
expired := newFinished("d-expired", metav1.NewTime(time.Now().Add(-2*time.Hour)))
fresh := newFinished("d-fresh", metav1.NewTime(time.Now().Add(-1*time.Second)))
c, s := newTestClient(t, expired, fresh)
r := &EtcdDefragReconciler{Client: c, Scheme: s, EtcdClientFactory: factoryReturning(newFakeEtcd(0xabc)), Recorder: record.NewFakeRecorder(20)}
if _, err := r.Reconcile(ctx, ctrl.Request{NamespacedName: nn("d-expired", "ns")}); err != nil {
t.Fatalf("reconcile d-expired: %v", err)
}
if err := c.Get(ctx, nn("d-expired", "ns"), &lll.EtcdDefrag{}); err == nil {
t.Fatal("expired EtcdDefrag was not garbage-collected")
} else if client.IgnoreNotFound(err) != nil {
t.Fatalf("get d-expired: %v", err)
}
res, err := r.Reconcile(ctx, ctrl.Request{NamespacedName: nn("d-fresh", "ns")})
if err != nil {
t.Fatalf("reconcile d-fresh: %v", err)
}
if res.RequeueAfter <= 0 || res.RequeueAfter > 3600*time.Second {
t.Fatalf("RequeueAfter = %s, want 0 < requeue <= 3600s", res.RequeueAfter)
}
if err := c.Get(ctx, nn("d-fresh", "ns"), &lll.EtcdDefrag{}); err != nil {
t.Fatalf("fresh EtcdDefrag was deleted before expiry: %v", err)
}
}
// A run that outlives the active deadline fails with DeadlineExceeded rather than
// lingering and holding the per-cluster slot.
func TestEtcdDefrag_DeadlineExceededFails(t *testing.T) {
cluster, members := defragCluster3()
started := metav1.NewTime(time.Now().Add(-defragActiveDeadline - time.Minute))
df := &lll.EtcdDefrag{
ObjectMeta: metav1.ObjectMeta{Name: "d1", Namespace: "ns"},
Spec: lll.EtcdDefragSpec{ClusterRef: corev1.LocalObjectReference{Name: "c1"}},
Status: lll.EtcdDefragStatus{Phase: lll.EtcdDefragPhaseRunning, StartedAt: &started},
}
c, s := newTestClient(t, objs(cluster, members, df)...)
fe := newFakeEtcd(0xabc)
fe.leader = 10
fe.statusErr = errors.New("context deadline exceeded") // cluster unreachable
rec := record.NewFakeRecorder(20)
r := &EtcdDefragReconciler{Client: c, Scheme: s, EtcdClientFactory: factoryReturning(fe), Recorder: rec}
if _, err := r.Reconcile(context.Background(), ctrl.Request{NamespacedName: nn("d1", "ns")}); err != nil {
t.Fatalf("reconcile: %v", err)
}
got := mustGet(t, c, "d1", "ns", &lll.EtcdDefrag{})
if got.Status.Phase != lll.EtcdDefragPhaseFailed {
t.Fatalf("phase = %q, want Failed", got.Status.Phase)
}
if cond := findDefragCond(got); cond == nil || cond.Reason != "DeadlineExceeded" {
t.Fatalf("DefragChecked = %+v, want DeadlineExceeded", cond)
}
assertDefragEvent(t, rec, "DeadlineExceeded")
}
// A run whose clusterRef names no EtcdCluster fails with ClusterNotFound.
func TestEtcdDefrag_ClusterNotFoundFails(t *testing.T) {
df := &lll.EtcdDefrag{ObjectMeta: metav1.ObjectMeta{Name: "d1", Namespace: "ns"}, Spec: lll.EtcdDefragSpec{ClusterRef: corev1.LocalObjectReference{Name: "nope"}}}
c, s := newTestClient(t, df)
rec := record.NewFakeRecorder(20)
r := &EtcdDefragReconciler{Client: c, Scheme: s, EtcdClientFactory: factoryReturning(newFakeEtcd(0xabc)), Recorder: rec}
if _, err := r.Reconcile(context.Background(), ctrl.Request{NamespacedName: nn("d1", "ns")}); err != nil {
t.Fatalf("reconcile: %v", err)
}
got := mustGet(t, c, "d1", "ns", &lll.EtcdDefrag{})
if got.Status.Phase != lll.EtcdDefragPhaseFailed {
t.Fatalf("phase = %q, want Failed", got.Status.Phase)
}
if cond := findDefragCond(got); cond == nil || cond.Reason != "ClusterNotFound" {
t.Fatalf("DefragChecked = %+v, want ClusterNotFound", cond)
}
assertDefragEvent(t, rec, "ClusterNotFound")
}
// The active deadline must outlast the worst-case serial sweep for the largest
// supported cluster: one member per pass, each probing every member then a
// stop-the-world Defragment and a requeue gap. This reads the constants the
// controller actually uses, so retuning any of them without widening the deadline
// fails the build.
func TestDefragActiveDeadlineCoversWorstCaseSweep(t *testing.T) {
worst := defragMaxSupportedMembers * (defragRPCTimeout + defragRequeueAfter + defragMaxSupportedMembers*defragStatusTimeout)
if defragActiveDeadline < worst {
t.Fatalf("defragActiveDeadline %s < worst-case sweep %s for %d members",
defragActiveDeadline, worst, defragMaxSupportedMembers)
}
}
func findDefragCond(df *lll.EtcdDefrag) *metav1.Condition {
for i := range df.Status.Conditions {
if df.Status.Conditions[i].Type == "DefragChecked" {
return &df.Status.Conditions[i]
}
}
return nil
}
func assertDefragEvent(t *testing.T, rec *record.FakeRecorder, wantReason string) {
t.Helper()
select {
case ev := <-rec.Events:
if !strings.Contains(ev, wantReason) {
t.Errorf("event = %q, want one mentioning %q", ev, wantReason)
}
default:
t.Errorf("no event emitted, want one mentioning %q", wantReason)
}
}
// Before the leader is defragmented, leadership is handed to a follower — and
// the MoveLeader RPC is issued on a client dialled at the leader alone, since
// etcd answers it nowhere else.
func TestEtcdDefrag_MovesLeadershipBeforeDefragmentingLeader(t *testing.T) {
cluster, members := defragCluster3()
df := &lll.EtcdDefrag{
ObjectMeta: metav1.ObjectMeta{Name: "d1", Namespace: "ns"},
Spec: lll.EtcdDefragSpec{ClusterRef: corev1.LocalObjectReference{Name: "c1"}, Rule: &lll.DefragRule{All: true}},
}
c, _ := newTestClient(t, objs(cluster, members, df)...)
fe := newFakeEtcd(0xabc)
fe.leader = 10
fe.statusByEndpoint = map[string]*clientv3.StatusResponse{
defragEndpoint("c1-0"): status(10, 10, 600<<20, 100<<20), // leader
defragEndpoint("c1-1"): status(11, 10, 600<<20, 100<<20),
defragEndpoint("c1-2"): status(12, 10, 600<<20, 100<<20),
}
var dialled [][]string
r := &EtcdDefragReconciler{Client: c, Scheme: testScheme(t),
EtcdClientFactory: factoryRecordingEndpoints(fe, &dialled), Recorder: record.NewFakeRecorder(30)}
out := driveDefrag(t, r, c, "d1")
if out.Status.Phase != lll.EtcdDefragPhaseComplete {
t.Fatalf("phase = %s, want Complete", out.Status.Phase)
}
if len(fe.moveLeaderCalls) != 1 {
t.Fatalf("moveLeaderCalls = %v, want exactly one transfer (for the leader)", fe.moveLeaderCalls)
}
// Transferee must be a voting follower, never the leader itself.
if got := fe.moveLeaderCalls[0]; got == 10 {
t.Errorf("leadership transferred to the leader itself (%d)", got)
}
// The transfer must have gone out on a leader-only client.
var sawLeaderOnly bool
for _, eps := range dialled {
if len(eps) == 1 && eps[0] == defragEndpoint("c1-0") {
sawLeaderOnly = true
}
}
if !sawLeaderOnly {
t.Errorf("no client was dialled at the leader alone; dialled = %v", dialled)
}
// The leader is still defragmented, and last.
if n := len(fe.defragCalls); n != 3 || fe.defragCalls[n-1] != defragEndpoint("c1-0") {
t.Errorf("defragCalls = %v, want all three with the leader last", fe.defragCalls)
}
}
// A learner is not a voting member and etcd rejects a transfer to one, so it is
// never chosen as the transferee.
func TestEtcdDefrag_NeverTransfersLeadershipToALearner(t *testing.T) {
cluster, members := defragCluster3()
df := &lll.EtcdDefrag{
ObjectMeta: metav1.ObjectMeta{Name: "d1", Namespace: "ns"},
Spec: lll.EtcdDefragSpec{ClusterRef: corev1.LocalObjectReference{Name: "c1"}, Rule: &lll.DefragRule{All: true}},
}
c, _ := newTestClient(t, objs(cluster, members, df)...)
learner := status(11, 10, 600<<20, 100<<20)
learner.IsLearner = true
fe := newFakeEtcd(0xabc)
fe.leader = 10
fe.statusByEndpoint = map[string]*clientv3.StatusResponse{
defragEndpoint("c1-0"): status(10, 10, 600<<20, 100<<20), // leader
defragEndpoint("c1-1"): learner,
defragEndpoint("c1-2"): status(12, 10, 600<<20, 100<<20),
}
r := &EtcdDefragReconciler{Client: c, Scheme: testScheme(t),
EtcdClientFactory: factoryReturning(fe), Recorder: record.NewFakeRecorder(30)}
driveDefrag(t, r, c, "d1")
if len(fe.moveLeaderCalls) != 1 || fe.moveLeaderCalls[0] != 12 {
t.Errorf("moveLeaderCalls = %v, want the voting follower 12, not the learner 11", fe.moveLeaderCalls)
}
}
// A single-member cluster has nowhere to move leadership to, so no transfer is
// attempted and the sweep still runs.
func TestEtcdDefrag_SingleMemberSkipsLeadershipTransfer(t *testing.T) {
cluster, members := defragCluster3()
cluster.Status.Observed.Replicas = 1
cluster.Spec.Replicas = ptrInt32(1)
members = members[:1]
df := &lll.EtcdDefrag{
ObjectMeta: metav1.ObjectMeta{Name: "d1", Namespace: "ns"},
Spec: lll.EtcdDefragSpec{ClusterRef: corev1.LocalObjectReference{Name: "c1"}, Rule: &lll.DefragRule{All: true}},
}
c, _ := newTestClient(t, objs(cluster, members, df)...)
fe := newFakeEtcd(0xabc)
fe.leader = 10
fe.statusByEndpoint = map[string]*clientv3.StatusResponse{
defragEndpoint("c1-0"): status(10, 10, 600<<20, 100<<20),
}
rec := record.NewFakeRecorder(30)
r := &EtcdDefragReconciler{Client: c, Scheme: testScheme(t),
EtcdClientFactory: factoryReturning(fe), Recorder: rec}
out := driveDefrag(t, r, c, "d1")
if len(fe.moveLeaderCalls) != 0 {
t.Errorf("attempted a leadership transfer on a single-member cluster: %v", fe.moveLeaderCalls)
}
if out.Status.Defragmented != 1 {
t.Errorf("defragmented = %d, want the sole member still defragmented", out.Status.Defragmented)
}
// The guard exists to keep this quiet: without it the sole member is treated
// as a transfer candidate that cannot be satisfied, and every single-member
// defrag warns about a transfer nobody asked for.
for len(rec.Events) > 0 {
if ev := <-rec.Events; strings.Contains(ev, "LeadershipTransferFailed") {
t.Errorf("spurious transfer-failure event on a single-member cluster: %s", ev)
}
}
}
// A failed transfer must not abandon a sweep the health gate already cleared:
// the leader is defragmented in place (today's behaviour) and the operator is
// told via an event.
func TestEtcdDefrag_LeadershipTransferFailureStillDefragments(t *testing.T) {
cluster, members := defragCluster3()
df := &lll.EtcdDefrag{
ObjectMeta: metav1.ObjectMeta{Name: "d1", Namespace: "ns"},
Spec: lll.EtcdDefragSpec{ClusterRef: corev1.LocalObjectReference{Name: "c1"}, Rule: &lll.DefragRule{All: true}},
}
c, _ := newTestClient(t, objs(cluster, members, df)...)
fe := newFakeEtcd(0xabc)
fe.leader = 10
fe.moveLeaderErr = errors.New("etcdserver: not leader")
fe.statusByEndpoint = map[string]*clientv3.StatusResponse{
defragEndpoint("c1-0"): status(10, 10, 600<<20, 100<<20),
defragEndpoint("c1-1"): status(11, 10, 600<<20, 100<<20),
defragEndpoint("c1-2"): status(12, 10, 600<<20, 100<<20),
}
rec := record.NewFakeRecorder(30)
r := &EtcdDefragReconciler{Client: c, Scheme: testScheme(t),
EtcdClientFactory: factoryReturning(fe), Recorder: rec}
out := driveDefrag(t, r, c, "d1")
if out.Status.Phase != lll.EtcdDefragPhaseComplete || out.Status.Defragmented != 3 {
t.Fatalf("phase=%s defragmented=%d, want Complete/3 despite the failed transfer",
out.Status.Phase, out.Status.Defragmented)
}
var sawEvent bool
for len(rec.Events) > 0 {
if strings.Contains(<-rec.Events, "LeadershipTransferFailed") {
sawEvent = true
}
}
if !sawEvent {
t.Error("no LeadershipTransferFailed event; a silent fallback hides the election risk")
}
}