Visitar URL original
release_next.sh drops pin comments in the snapshot and has no guard for a bare --release-tag · Issue #734 · cozystack/website · GitHub
Skip to content

release_next.sh drops pin comments in the snapshot and has no guard for a bare --release-tag #734

Open

Description

Two small rough edges in hack/release_next.sh, both there before #710.

The snapshot step pins cozystack_version and cozystack_tag with a sed that replaces everything after the key. That also drops the trailing comments next.yaml carries on those lines (# bare, as used by helm --version and # v-prefixed, as used in GitHub URLs). You can see it in data/versions/v1.6.yaml, where both lines have no comment. Matching only the quoted value, for example s|^\(cozystack_tag:[[:space:]]*\)"[^"]*"|\1"${RELEASE_TAG}"|, keeps the comment.

--release-tag without a value reads $2 under set -u and dies with "unbound variable" instead of the usage error. hack/update_versions.sh checks $# -lt 2 for its value-taking flags, and the same guard fits here.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions