Repository navigation
Expand file tree
/
Copy pathtestincompletestatement.cpp
More file actions
266 lines (225 loc) · 7.18 KB
/
Copy pathtestincompletestatement.cpp
File metadata and controls
266 lines (225 loc) · 7.18 KB
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
/*
* Cppcheck - A tool for static C/C++ code analysis
* Copyright (C) 2007-2015 Daniel Marjamäki and Cppcheck team.
*
* This program is free software: you can redistribute it and/or modify
* it under the terms of the GNU General Public License as published by
* the Free Software Foundation, either version 3 of the License, or
* (at your option) any later version.
*
* This program is distributed in the hope that it will be useful,
* but WITHOUT ANY WARRANTY; without even the implied warranty of
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
* GNU General Public License for more details.
*
* You should have received a copy of the GNU General Public License
* along with this program. If not, see <http://www.gnu.org/licenses/>.
*/
#include "testsuite.h"
#include "tokenize.h"
#include "checkother.h"
class TestIncompleteStatement : public TestFixture {
public:
TestIncompleteStatement() : TestFixture("TestIncompleteStatement") {
}
private:
void check(const char code[]) {
// Clear the error buffer..
errout.str("");
Settings settings;
settings.addEnabled("warning");
// Tokenize..
Tokenizer tokenizer(&settings, this);
std::istringstream istr(code);
tokenizer.tokenize(istr, "test.cpp");
tokenizer.simplifyTokenList2();
// Check for incomplete statements..
CheckOther checkOther(&tokenizer, &settings, this);
checkOther.checkIncompleteStatement();
}
void run() {
TEST_CASE(test1);
TEST_CASE(test2);
TEST_CASE(test3);
TEST_CASE(test4);
TEST_CASE(test5);
TEST_CASE(test6);
TEST_CASE(test_numeric);
TEST_CASE(void0); // #6327: No fp for statement "(void)0;"
TEST_CASE(intarray);
TEST_CASE(structarraynull);
TEST_CASE(structarray);
TEST_CASE(conditionalcall); // ; 0==x ? X() : Y();
TEST_CASE(structinit); // #2462 : ABC abc{1,2,3};
TEST_CASE(returnstruct);
TEST_CASE(cast); // #3009 : (struct Foo *)123.a = 1;
TEST_CASE(increment); // #3251 : FP for increment
TEST_CASE(cpp11init); // #5493 : int i{1};
TEST_CASE(block); // ({ do_something(); 0; })
}
void test1() {
check("void foo()\n"
"{\n"
" const char def[] =\n"
" \"abc\";\n"
"}");
ASSERT_EQUALS("", errout.str());
}
void test2() {
check("void foo()\n"
"{\n"
" \"abc\";\n"
"}");
ASSERT_EQUALS("[test.cpp:3]: (warning) Redundant code: Found a statement that begins with string constant.\n", errout.str());
}
void test3() {
check("void foo()\n"
"{\n"
" const char *str[] = { \"abc\" };\n"
"}");
ASSERT_EQUALS("", errout.str());
}
void test4() {
check("void foo()\n"
"{\n"
"const char *a =\n"
"{\n"
"\"hello \"\n"
"\"more \"\n"
"\"world\"\n"
"};\n"
"}");
ASSERT_EQUALS("", errout.str());
}
void test5() {
check("void foo()\n"
"{\n"
" 50;\n"
"}");
ASSERT_EQUALS("[test.cpp:3]: (warning) Redundant code: Found a statement that begins with numeric constant.\n", errout.str());
}
void test6() {
// dont crash
check("void f() {\n"
" 1 == (two + three);\n"
" 2 != (two + three);\n"
" (one + two) != (two + three);\n"
"}");
}
void test_numeric() {
check("struct P\n"
"{\n"
"double a;\n"
"double b;\n"
"};\n"
"void f()\n"
"{\n"
"const P values[2] =\n"
"{\n"
"{ 346.1,114.1 }, { 347.1,111.1 }\n"
"};\n"
"}");
ASSERT_EQUALS("", errout.str());
}
void void0() { // #6327
check("void f() { (void*)0; }");
ASSERT_EQUALS("", errout.str());
check("void f() { $0; }");
ASSERT_EQUALS("", errout.str());
}
void intarray() {
check("int arr[] = { 100/2, 1*100 };");
ASSERT_EQUALS("", errout.str());
}
void structarraynull() {
check("struct st arr[] = {\n"
" { 100/2, 1*100 }\n"
" { 90, 70 }\n"
"}");
ASSERT_EQUALS("", errout.str());
}
void structarray() {
check("struct st arr[] = {\n"
" { 100/2, 1*100 }\n"
" { 90, 70 }\n"
"};");
ASSERT_EQUALS("", errout.str());
}
void conditionalcall() {
check("void f() {\n"
" 0==x ? X() : Y();\n"
"}");
ASSERT_EQUALS("", errout.str());
}
void structinit() {
// #2462 - C++11 struct initialization
check("void f() {\n"
" ABC abc{1,2,3};\n"
"}");
ASSERT_EQUALS("", errout.str());
// #6260 - C++11 array initialization
check("void foo() {\n"
" static const char* a[][2] {\n"
" {\"b\", \"\"},\n"
" };\n"
"}");
ASSERT_EQUALS("", errout.str());
// #2482 - false positive for empty struct
check("struct A {};");
ASSERT_EQUALS("", errout.str());
// #4387 - C++11 initializer list
check("A::A() : abc{0} {}");
ASSERT_EQUALS("", errout.str());
// #5042 - C++11 initializer list
check("A::A() : abc::def<int>{0} {}");
ASSERT_EQUALS("", errout.str());
// #4503 - vector init
check("void f() { vector<int> v{1}; }");
ASSERT_EQUALS("", errout.str());
}
void returnstruct() {
check("struct s foo() {\n"
" return (struct s){0,0};\n"
"}");
ASSERT_EQUALS("", errout.str());
// #4754
check("unordered_map<string, string> foo() {\n"
" return {\n"
" {\"hi\", \"there\"},\n"
" {\"happy\", \"sad\"}\n"
" };\n"
"}");
ASSERT_EQUALS("", errout.str());
}
void cast() {
check("void f() {\n"
" ((struct foo *)(0x1234))->xy = 1;\n"
"}");
ASSERT_EQUALS("", errout.str());
}
void increment() {
check("void f() {\n"
" int x = 1;\n"
" x++, x++;\n"
"}");
ASSERT_EQUALS("", errout.str());
}
void cpp11init() {
check("void f() {\n"
" int x{1};\n"
"}");
ASSERT_EQUALS("", errout.str());
}
void block() {
check("void f() {\n"
" ({ do_something(); 0; });\n"
"}");
ASSERT_EQUALS("", errout.str());
check("void f() {\n"
"out:\n"
" ({ do_something(); 0; });\n"
"}");
ASSERT_EQUALS("", errout.str());
}
};
REGISTER_TEST(TestIncompleteStatement)