Visitar URL original
[xdg_directories] Swap flutter dependencies out (#195) · creatorpiyush/packages@72bc4f3 · GitHub
Skip to content

Commit 72bc4f3

Browse files
author
James Chen-Smith
authored
[xdg_directories] Swap flutter dependencies out (flutter#195)
I didn't notice a need to depend on flutter packages when they could be replaced with the more specific libraries. I opted to go for the latest versions.
1 parent 4adcb25 commit 72bc4f3

3 files changed

Lines changed: 8 additions & 6 deletions

File tree

‎packages/xdg_directories/lib/xdg_directories.dart‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@ library xdg_directories;
77
import 'dart:convert';
88
import 'dart:io';
99

10-
import 'package:flutter/cupertino.dart';
10+
import 'package:meta/meta.dart';
1111
import 'package:path/path.dart' as path;
1212
import 'package:process/process.dart';
1313

‎packages/xdg_directories/pubspec.yaml‎

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -7,12 +7,10 @@ environment:
77
sdk: ">=2.3.0 <3.0.0"
88

99
dependencies:
10+
meta: ^1.2.2
1011
path: ^1.6.4
1112
process: ^3.0.12
12-
flutter:
13-
sdk: flutter
1413

1514
dev_dependencies:
15+
test: ^1.15.3
1616
mockito: ^4.1.1
17-
flutter_test:
18-
sdk: flutter

‎packages/xdg_directories/test/xdg_directories_test.dart‎

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@
55
import 'dart:convert';
66
import 'dart:io';
77

8-
import 'package:flutter_test/flutter_test.dart';
8+
import 'package:test/test.dart';
99
import 'package:path/path.dart' as path;
1010
import 'package:mockito/mockito.dart' show Fake;
1111
import 'package:process/process.dart';
@@ -46,6 +46,7 @@ XDG_VIDEOS_DIR="$HOME/Videos"
4646
''');
4747
xdg.xdgEnvironmentOverride = (String key) => fakeEnv[key];
4848
});
49+
4950
tearDown(() {
5051
if (tmpDir != null) {
5152
tmpDir.deleteSync(recursive: true);
@@ -70,6 +71,7 @@ XDG_VIDEOS_DIR="$HOME/Videos"
7071
expectDirList(xdg.configDirs, <String>['/etc/xdg']);
7172
expectDirList(xdg.dataDirs, <String>['/usr/local/share', '/usr/share']);
7273
});
74+
7375
test('Values pull from environment', () {
7476
expect(xdg.cacheHome.path, equals(testPath('.test_cache')));
7577
expect(xdg.configHome.path, equals(testPath('.test_config')));
@@ -82,6 +84,7 @@ XDG_VIDEOS_DIR="$HOME/Videos"
8284
testPath('usr/test_share'),
8385
]);
8486
});
87+
8588
test('Can get userDirs', () {
8689
final Map<String, String> expected = <String, String>{
8790
'DESKTOP': testPath('Desktop'),
@@ -102,6 +105,7 @@ XDG_VIDEOS_DIR="$HOME/Videos"
102105
}
103106
xdg.xdgProcessManager = const LocalProcessManager();
104107
});
108+
105109
test('Throws StateError when HOME not set', () {
106110
fakeEnv.clear();
107111
expect(() {

0 commit comments

Comments
 (0)