Visitar URL original
[pigeon] removed warnings from Dart generated code (#123) · creatorpiyush/packages@b0f543b · GitHub
Skip to content

Commit b0f543b

Browse files
authored
[pigeon] removed warnings from Dart generated code (flutter#123)
1 parent 87f7821 commit b0f543b

5 files changed

Lines changed: 12 additions & 2 deletions

File tree

‎packages/pigeon/CHANGELOG.md‎

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,7 @@
1+
## 0.1.0-experimental.7
2+
3+
* Suppressed or got rid of warnings in generated Dart code.
4+
15
## 0.1.0-experimental.6
26

37
* Added support for void return types.

‎packages/pigeon/lib/dart_generator.dart‎

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -92,6 +92,8 @@ void generateDart(Root root, StringSink sink) {
9292
final Indent indent = Indent(sink);
9393
indent.writeln('// $generatedCodeWarning');
9494
indent.writeln('// $seeAlsoWarning');
95+
indent.writeln('// ignore_for_file: public_member_api_docs');
96+
indent.writeln('import \'dart:async\';');
9597
indent.writeln('import \'package:flutter/services.dart\';');
9698
indent.writeln('');
9799

‎packages/pigeon/lib/generator_tools.dart‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@ import 'dart:mirrors';
88
import 'ast.dart';
99

1010
/// The current version of pigeon.
11-
const String pigeonVersion = '0.1.0-experimental.6';
11+
const String pigeonVersion = '0.1.0-experimental.7';
1212

1313
/// Read all the content from [stdin] to a String.
1414
String readStdin() {

‎packages/pigeon/pubspec.yaml‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
name: pigeon
2-
version: 0.1.0-experimental.6
2+
version: 0.1.0-experimental.7
33
description: Code generator tool to make communication between Flutter and the host platform type-safe and easier.
44
homepage: https://github.com/flutter/packages/tree/master/packages/pigeon
55
dependencies:

‎packages/pigeon/run_tests.sh‎

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -49,10 +49,14 @@ test_pigeon_android() {
4949
}
5050

5151
pub run test test/
52+
test_pigeon_android ./pigeons/voidflutter.dart
53+
test_pigeon_android ./pigeons/voidhost.dart
5254
test_pigeon_android ./pigeons/host2flutter.dart
5355
test_pigeon_android ./pigeons/message.dart
5456
test_pigeon_ios ./pigeons/message.dart
5557
test_pigeon_ios ./pigeons/host2flutter.dart
58+
test_pigeon_ios ./pigeons/voidhost.dart
59+
test_pigeon_ios ./pigeons/voidflutter.dart
5660

5761
pub run pigeon \
5862
--input pigeons/message.dart \

0 commit comments

Comments
 (0)