Part 5: page_num out of bounds #102

Activity

1. skypaver commented on Aug 8, 2023

   

   skypaver

   on Aug 8, 2023

   Last edited by skypaver

   More actions

   I noticed the same problem. I think you're right.

   Maybe there's a similar problem also in the function get_page (line 248 in db.c):

   void* get_page(Pager* pager, uint32_t page_number){
       ...
       if (page_num <= num_pages) {
           lseek(pager->file_descriptor, page_num * PAGE_SIZE, SEEK_SET);
           ...
       }
       ...
    }
   

   (line 248 in db.c)if (page_num <= num_pages) I think it should be if (page_num < num_pages). Since the page_num is an index starts from 0 to TABLE_MAX_PAGE - 1, and the num_pages starts from 1.

   I'm not quite sure. Could you please tell me if I am right or wrong? Thanks so much.

   👍React with 👍2Reacted by Kirchoff and Tyler Swann