Repository navigation
sort_pub_dependencies false positive #58241
Description
Repro:
name: animations
description: Fancy pre-built animations that can easily be integrated into any Flutter application.
version: 1.1.1
homepage: https://github.com/flutter/packages/tree/master/packages/animations
environment:
sdk: ">=2.2.2 <3.0.0"
dependencies:
flutter:
sdk: flutter
dev_dependencies:
flutter_test:
sdk: flutter
vector_math: ^2.0.8See failure: https://cirrus-ci.com/task/5329170379046912
/fyi @dnfield
Reacted by Dan Field
Activity
disable pubspec linting
pq commentedon Oct 8, 2020
Hmmmm... I'm not getting this to repro locally. Looking at the reported failure, I wonder if this wasn't actually a mis-report?
The test failure was flagging
example/pubspec.yamlwhich is in fact not sorted:
https://github.com/flutter/packages/blob/837b1a321d3f00034556ef5b385abb93c0843715/packages/animations/example/pubspec.yaml
Whereas we were looking at the root pubspec above (and that seems ok).
🤔
/cc @dnfield
dnfield commentedon Oct 8, 2020
Ah! you are right.
I will file a fix for the animations package.
dnfield commentedon Oct 8, 2020
flutter/packages#220
pq commentedon Oct 8, 2020
Sweet!
pq commentedon Oct 8, 2020
When I un-revert (and for future reference), is there an easy way for me to test pro-actively if an engine roll would be blocked by a given SDK commit?