Repository navigation
RandomAccessVectorValues::threadLocalSupplier leaks objects #635
Description
The current implementations:
default Supplier<RandomAccessVectorValues> threadLocalSupplier() {
if (!isValueShared()) {
return () -> this;
}
if (this instanceof AutoCloseable) {
LOG.warning("RAVV is shared and implements AutoCloseable; threadLocalSupplier() may lead to leaks");
}
var tl = ExplicitThreadLocal.withInitial(this::copy);
return tl::get;
}I'd like to see if we can find an elegant solution that allows us to remove the warning log and properly close resources when they implement AutoCloseable.
Activity
Refactor implementation again to be thread safe
ikaitist commentedon Aug 24, 2026
I would like to work on this. Root cause: the default threadLocalSupplier() creates per-thread copies via ExplicitThreadLocal and never closes them (the code itself warns when the RAVV is AutoCloseable). Consumers holding the supplier across pooled threads keep those copies and their backing memory alive indefinitely.
I see two directions and would welcome a maintainer call:
Happy to implement whichever direction you prefer, with tests.