OOM killed when using headers with file with relative import #60

Activity

1. Gabriella439 commented on Oct 2, 2018

   

   Gabriella439

   on Oct 2, 2018

   Collaborator

   More actions

   I can reproduce:

   $ dhall <<< 'https://gist.githubusercontent.com/reactormonk/a8192fe784608f1f7515d5583c448095/raw/d46f5b9aea9eb56c4bdd92d187936ee87e9f4cf2/local.dhall'
   <Ctrl-C>
   ...
   
   ↳ https://gist.githubusercontent.com/reactormonk/a8192fe784608f1f7515d5583c448095/raw/d46f5b9aea9eb56c4bdd92d187936ee87e9f4cf2/local.dhall
     ↳ https://gist.githubusercontent.com/reactormonk/a8192fe784608f1f7515d5583c448095/raw/e8e5b14c2afe9acc342fe111bcf6e09b90dced9c/test.dhall using ./headers
       ↳ https://gist.githubusercontent.com/reactormonk/a8192fe784608f1f7515d5583c448095/raw/e8e5b14c2afe9acc342fe111bcf6e09b90dced9c/headers
   
   ↳ https://gist.githubusercontent.com/reactormonk/a8192fe784608f1f7515d5583c448095/raw/d46f5b9aea9eb56c4bdd92d187936ee87e9f4cf2/local.dhall
     ↳ https://gist.githubusercontent.com/reactormonk/a8192fe784608f1f7515d5583c448095/raw/e8e5b14c2afe9acc342fe111bcf6e09b90dced9c/test.dhall using ./headers
       ↳ https://gist.githubusercontent.com/reactormonk/a8192fe784608f1f7515d5583c448095/raw/e8e5b14c2afe9acc342fe111bcf6e09b90dced9c/headers
   

   I'm investigating why
2. Gabriella439 commented on Oct 2, 2018

   

   Gabriella439

   on Oct 2, 2018

   Collaborator

   More actions

   Oh, so the issue here is due to custom headers being used to configure their own import, which triggers an infinite recursion. Let me see if this is simple to fix
3. Gabriella439

   added a commit that references this issue on Oct 4, 2018

   Fix import chaining for custom header support

   ...

   26a4cb4
4. Gabriella439 commented on Oct 4, 2018

   

   Gabriella439

   on Oct 4, 2018

   Collaborator

   More actions

   I found the bug. The fix is up here: dhall-lang/dhall-haskell#618
5. Gabriella439

   closed this as completedin dhall-haskell#618on Oct 4, 2018
6. Gabriella439

   added a commit that references this issue on Oct 4, 2018

   Fix import chaining for custom header support (#618)

   ...

   3b3c14b
7. reactormonk commented on Oct 5, 2018

   

   reactormonk

   on Oct 5, 2018

   Author

   More actions

   Could you cut a new binary release?
8. Gabriella439 commented on Oct 5, 2018

   

   Gabriella439

   on Oct 5, 2018

   Collaborator

   More actions

   @reactormonk: We're not ready to cut a release yet because there are some in-flight changes to the standard. However, you can download a prerelease build of dhall-json from here:

   http://hydra.dhall-lang.org/job/dhall-json/master/tarball/latest