This repository was archived by the owner on Jul 18, 2025. It is now read-only.
Repository navigation
This repository was archived by the owner on Jul 18, 2025. It is now read-only.
Hijack is incompatible with use of CloseNotifier #303
Description
This is caused by moby/moby#12845
package main
import (
"fmt"
"io/ioutil"
"github.com/docker/engine-api/client"
"github.com/docker/engine-api/types"
"golang.org/x/net/context"
)
// Some basic nginx container running
const ContainerID string = "ce5d8b318ca0"
func main() {
c, _ := client.NewClient("unix:///var/run/docker.sock", "", nil, nil)
body, _ := c.ContainerLogs(context.Background(), ContainerID, types.ContainerLogsOptions{
ShowStdout: true,
ShowStderr: true,
})
defer body.Close()
// This line causes ContainerExecStart to fail with
// Error response from daemon: http: Hijack is incompatible with use of CloseNotifier
_, _ = ioutil.ReadAll(body)
exec, _ := c.ContainerExecCreate(context.Background(), ContainerID, types.ExecConfig{
Cmd: []string{"date"},
})
err := c.ContainerExecStart(context.Background(), exec.ID, types.ExecStartCheck{})
fmt.Println(err)
}$ go run engine-api-bug.go
Error response from daemon: http: Hijack is incompatible with use of CloseNotifierHow can I fix this with engine-api?
Activity
Create new Docker client for PrepareBackup (fix #70)
cpuguy83 commentedon Jul 5, 2016
This is likely from connection re-use, which is automatic from the http package.
In the client transport we'll either need to set
DisableKeepAlivesor maybe inContainerExecStartwe can make sure to setClosein the request?raphink commentedon Jul 5, 2016
This should work. Currently, I have to create a new Docker client for the
ContainerExecStart.cpuguy83 commentedon Jul 5, 2016
This could probably be considered a golang bug. We should not have to manually manage this when the http package knows we've hijacked the connection.
LK4D4 commentedon Jul 5, 2016
I belive fix for this was on go1.6
golang/go@99fb191
cpuguy83 commentedon Jul 5, 2016
It would seem so.
@raphink any chance you can test with go 1.6?
raphink commentedon Jul 5, 2016
I get this bug with all versions of go, including tip. I think it's the docker engine that needs to be rebuilt with the new version of go.
thaJeztah commentedon Jul 5, 2016
@cpuguy83 @LK4D4 saw that someone reported this issue on 1.12-rc3 (which uses go 1.6); moby/moby#12845 (comment)